Web MIDI: make input_ports_ and output_ports_ members private

media/midi/midi_manager_win.cc

Index: media/midi/midi_manager_win.cc
diff --git a/media/midi/midi_manager_win.cc b/media/midi/midi_manager_win.cc
index a4222995c1accda677773eeae6330177cab6d5fa..f8cf46995d3aecce3746d3fe923fafbfcc887479 100644
--- a/media/midi/midi_manager_win.cc
+++ b/media/midi/midi_manager_win.cc
@@ -516,7 +516,7 @@ void MidiManagerWin::StartInitialization() {
         base::WideToUTF8(caps.szPname),
         base::IntToString(static_cast<int>(caps.vDriverVersion)));
     AddInputPort(info);
-    in_device->set_port_index(input_ports_.size() - 1);
+    in_device->set_port_index(get_input_ports().size() - 1);
     in_devices_.push_back(in_device.Pass());
   }
 
@@ -548,14 +548,13 @@ void MidiManagerWin::StartInitialization() {
 MidiManagerWin::~MidiManagerWin() {
   // Cleanup order is important. |send_thread_| must be stopped before
   // |out_devices_| is cleared.
-  for (size_t i = 0; i < output_ports_.size(); ++i)
+  for (size_t i = 0; i < get_output_ports().size(); ++i)
     out_devices_[i]->Quit();
   send_thread_.Stop();
 
   out_devices_.clear();
-  output_ports_.clear();
   in_devices_.clear();
-  input_ports_.clear();
+  ClearInputOutputPorts();

[Takashi Toyoshima, 2014/05/06 23:12:11]

BTW, Yukawa-san, do you remember why ports should be clear by not MidiManager
but derived win specific class?

[yukawa, 2014/05/07 00:29:57]

Hmm, I don't know. An important rule here is that we should wait for the
completion of |send_thread_| before manipulating {in/out}ports. However, I don't
know if we need to clear ports in each derived class. I think it is safe to
clear them MidiManager.

(bonus point if we put const for each field in MidiPortInfo.)

[Takashi Toyoshima, 2014/05/07 02:28:26]

OK, so I just remove it.

For making MidiPostInfoList std::vector<const MidiPortInfo>, it seems not to be
simple since IPC macros, IPC_STRUCT_TRAITS_*, use move operation for
serializing/deserializing.

 }
 
 void MidiManagerWin::DispatchSendMidiData(MidiManagerClient* client,