Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 269543028: Web MIDI: make input_ports_ and output_ports_ members private (Closed)

Created:
6 years, 7 months ago by Takashi Toyoshima
Modified:
6 years, 7 months ago
Reviewers:
yukawa
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Web MIDI: make input_ports_ and output_ports_ members private Minor cleanup changes of r268533. Make input_ports_ and output_ports_ members private too. NOTRY=true BUG=344759 TEST=media_unittests -gtest_filter='*Midi*' Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268856

Patch Set 1 #

Total comments: 7

Patch Set 2 : review #2 #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -24 lines) Patch
M media/midi/midi_manager.h View 1 2 3 chunks +7 lines, -8 lines 0 comments Download
M media/midi/midi_manager_unittest.cc View 1 2 7 chunks +14 lines, -12 lines 0 comments Download
M media/midi/midi_manager_win.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Takashi Toyoshima
Can you take a look? https://codereview.chromium.org/269543028/diff/1/media/midi/midi_manager_win.cc File media/midi/midi_manager_win.cc (right): https://codereview.chromium.org/269543028/diff/1/media/midi/midi_manager_win.cc#newcode557 media/midi/midi_manager_win.cc:557: ClearInputOutputPorts(); BTW, Yukawa-san, do ...
6 years, 7 months ago (2014-05-06 23:12:10 UTC) #1
yukawa
https://codereview.chromium.org/269543028/diff/1/media/midi/midi_manager.h File media/midi/midi_manager.h (right): https://codereview.chromium.org/269543028/diff/1/media/midi/midi_manager.h#newcode94 media/midi/midi_manager.h:94: const MidiPortInfoList& get_input_ports() { return input_ports_; } ... const ...
6 years, 7 months ago (2014-05-07 00:29:56 UTC) #2
Takashi Toyoshima
PTAL Patch Set 2. https://codereview.chromium.org/269543028/diff/1/media/midi/midi_manager.h File media/midi/midi_manager.h (right): https://codereview.chromium.org/269543028/diff/1/media/midi/midi_manager.h#newcode94 media/midi/midi_manager.h:94: const MidiPortInfoList& get_input_ports() { return ...
6 years, 7 months ago (2014-05-07 02:28:26 UTC) #3
yukawa
Thank. LGTM.
6 years, 7 months ago (2014-05-07 02:33:11 UTC) #4
Takashi Toyoshima
The CQ bit was checked by toyoshim@chromium.org
6 years, 7 months ago (2014-05-07 12:41:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/269543028/30001
6 years, 7 months ago (2014-05-07 12:42:27 UTC) #6
Takashi Toyoshima
The CQ bit was unchecked by toyoshim@chromium.org
6 years, 7 months ago (2014-05-07 15:50:52 UTC) #7
Takashi Toyoshima
The CQ bit was checked by toyoshim@chromium.org
6 years, 7 months ago (2014-05-07 15:51:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/269543028/30001
6 years, 7 months ago (2014-05-07 15:52:29 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-07 18:06:27 UTC) #10
Message was sent while issue was closed.
Change committed as 268856

Powered by Google App Engine
This is Rietveld 408576698