Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1514)

Unified Diff: media/midi/midi_manager_win.cc

Issue 269543028: Web MIDI: make input_ports_ and output_ports_ members private (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/midi/midi_manager_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/midi/midi_manager_win.cc
diff --git a/media/midi/midi_manager_win.cc b/media/midi/midi_manager_win.cc
index a4222995c1accda677773eeae6330177cab6d5fa..54a1db8733a90db5b00fe802413df182f7b5e339 100644
--- a/media/midi/midi_manager_win.cc
+++ b/media/midi/midi_manager_win.cc
@@ -516,7 +516,7 @@ void MidiManagerWin::StartInitialization() {
base::WideToUTF8(caps.szPname),
base::IntToString(static_cast<int>(caps.vDriverVersion)));
AddInputPort(info);
- in_device->set_port_index(input_ports_.size() - 1);
+ in_device->set_port_index(input_ports().size() - 1);
in_devices_.push_back(in_device.Pass());
}
@@ -548,14 +548,12 @@ void MidiManagerWin::StartInitialization() {
MidiManagerWin::~MidiManagerWin() {
// Cleanup order is important. |send_thread_| must be stopped before
// |out_devices_| is cleared.
- for (size_t i = 0; i < output_ports_.size(); ++i)
+ for (size_t i = 0; i < output_ports().size(); ++i)
out_devices_[i]->Quit();
send_thread_.Stop();
out_devices_.clear();
- output_ports_.clear();
in_devices_.clear();
- input_ports_.clear();
}
void MidiManagerWin::DispatchSendMidiData(MidiManagerClient* client,
« no previous file with comments | « media/midi/midi_manager_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698