Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2695423002: [Devtools] Added provider for NetworkLookupInterface to ProductRegistry (Closed)

Created:
3 years, 10 months ago by allada
Modified:
3 years, 10 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Added provider for NetworkLookupInterface to ProductRegistry This patch completes the linking between Network and Product Registry. There should now be a dropdown in the top of the network panel that allows the user to group by product (found in the product registry module). R=pfeldman,dgozman BUG=664704 Review-Url: https://codereview.chromium.org/2695423002 Cr-Commit-Position: refs/heads/master@{#451239} Committed: https://chromium.googlesource.com/chromium/src/+/7234ea5d5045f6fedbc01503613cc26a2e264670

Patch Set 1 : Merge branch 'WIRE_NETWORK_GROUP_MODULE' into ADDED_NETWORK_GROUP_LOOKUP #

Patch Set 2 : changes #

Messages

Total messages: 17 (12 generated)
allada
PTL
3 years, 10 months ago (2017-02-16 02:55:45 UTC) #1
pfeldman
lgtm
3 years, 10 months ago (2017-02-16 22:19:10 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2698743003 Patch 60001). Please resolve the dependency and ...
3 years, 10 months ago (2017-02-17 04:11:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695423002/50001
3 years, 10 months ago (2017-02-17 06:06:11 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 06:14:31 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:50001) as
https://chromium.googlesource.com/chromium/src/+/7234ea5d5045f6fedbc01503613c...

Powered by Google App Engine
This is Rietveld 408576698