runtime/bin/extensions.h - Issue 2695403003: Undo rename of LoadExtensionLibrary to LoadLibrary since mangling on Windows seems to create a conf…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/extensions.h

Issue 2695403003: Undo rename of LoadExtensionLibrary to LoadLibrary since mangling on Windows seems to create a conf… (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/extensions.h

diff --git a/runtime/bin/extensions.h b/runtime/bin/extensions.h

index d4c7b33001d453f5efeca1d2a284deebeefe1688..de8bed94aad5a20979deb6ef5ba30620ae674292 100644

--- a/runtime/bin/extensions.h

+++ b/runtime/bin/extensions.h

@@ -20,7 +20,7 @@ class Extensions {

Dart_Handle parent_library);

// Platform-specific implementations.

- static void* LoadLibrary(const char* library_file);

+ static void* LoadExtensionLibrary(const char* library_file);

zra 2017/02/16 22:18:17 Add comment warning against re-nameing to LoadLibr

rmacnak 2017/02/16 22:21:30 Done.

static void* ResolveSymbol(void* lib_handle, const char* symbol);

static void UnloadLibrary(void* lib_handle);

« no previous file with comments | « no previous file | runtime/bin/extensions.cc » ('j') | no next file with comments »