Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Unified Diff: milo/appengine/logdog/build.go

Issue 2695383002: milo: Enable Swarming LogDog log loading. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: milo/appengine/logdog/build.go
diff --git a/milo/appengine/logdog/build.go b/milo/appengine/logdog/build.go
index 724517105ceb7dd154282858e47baed64ffbc3fa..a9cbf470add4e8afe3de122aff3adfc1bb09025c 100644
--- a/milo/appengine/logdog/build.go
+++ b/milo/appengine/logdog/build.go
@@ -44,7 +44,7 @@ type AnnotationStream struct {
Project cfgtypes.ProjectName
Path types.StreamPath
- // logDogClient is the HTTP client to use for LogDog communication.
+ // Client is the HTTP client to use for LogDog communication.
Client *coordinator.Client
// cs is the unmarshalled annotation stream Step and associated data.
@@ -212,12 +212,6 @@ func (as *AnnotationStream) Load(c context.Context) (*miloProto.Step, error) {
Finished: (state.State.TerminalIndex >= 0 && le.StreamIndex == uint64(state.State.TerminalIndex)),
}
- // Annotee is apparently not putting an ended time on some annotation protos.
- // This hack will ensure that a finished build will always have an ended time.
- if as.cs.Finished && as.cs.Step.Ended == nil {
- as.cs.Step.Ended = google.NewTimestamp(latestEndedTime)
- }
-
// Marshal and cache the step. If this is the final protobuf in the stream,
// cache it indefinitely; otherwise, cache it for intermediateCacheLifetime.
//

Powered by Google App Engine
This is Rietveld 408576698