milo: Enable Swarming LogDog log loading.

milo/appengine/logdog/build.go

 // Copyright 2016 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package logdog
 
 import (
         "fmt"
         "net/http"
         "time"
@@ skipping 26 matching lines @@
         // defaultLogDogHost is the default LogDog host, if one isn't specified via
         // query string.
         defaultLogDogHost = "luci-logdog.appspot.com"
 )
 
 // AnnotationStream represents a LogDog annotation protobuf stream.
 type AnnotationStream struct {
         Project cfgtypes.ProjectName
         Path    types.StreamPath
 
-        // logDogClient is the HTTP client to use for LogDog communication.
+        // Client is the HTTP client to use for LogDog communication.
         Client *coordinator.Client
 
         // cs is the unmarshalled annotation stream Step and associated data.
         cs internal.CachedStep
 }
 
 // Normalize validates and normalizes the stream's parameters.
 func (as *AnnotationStream) Normalize() error {
         if err := as.Project.Validate(); err != nil {
                 return fmt.Errorf("Invalid project name: %s", as.Project)
@@ skipping 147 matching lines @@
                 // No substep had an ended time :(
                 latestEndedTime = google.TimeFromProto(step.Started)
         }
 
         // Build our CachedStep.
         as.cs = internal.CachedStep{
                 Step:     &step,
                 Finished: (state.State.TerminalIndex >= 0 && le.StreamIndex == uint64(state.State.TerminalIndex)),
         }
 
-        // Annotee is apparently not putting an ended time on some annotation protos.
-        // This hack will ensure that a finished build will always have an ended time.
-        if as.cs.Finished && as.cs.Step.Ended == nil {
-                as.cs.Step.Ended = google.NewTimestamp(latestEndedTime)
-        }
-
         // Marshal and cache the step. If this is the final protobuf in the stream,
         // cache it indefinitely; otherwise, cache it for intermediateCacheLifetime.
         //
         // If this fails, it is non-fatal.
         mcData, err := proto.Marshal(&as.cs)
         if err == nil {
                 mcItem = mc.NewItem(c, mcKey)
                 if !as.cs.Finished {
                         mcItem.SetExpiration(intermediateCacheLifetime)
                 }
@@ skipping 78 matching lines @@
                 if link.Label == "" {
                         link.Label = "unnamed"
                 }
                 return &link
 
         default:
                 // Don't know how to render.
                 return nil
         }
 }