Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2695343002: Handle OffscreenCanvas.convertToBlob exceptions: EncodingError & InvalidStateError (Closed)

Created:
3 years, 10 months ago by xlai (Olivia)
Modified:
3 years, 9 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, Rik, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle OffscreenCanvas.convertToBlob exceptions: EncodingError & InvalidStateError This CL handle two new exceptions: 1. EncodingError exception when convertToBlob fails encoding; the test case we use here is to attempt encoding webp that exceeds max dimension. This is consistent with new spec change: https://github.com/whatwg/html/pull/2343 2. InvalidStateError exception when convertToBlob is calling on an OffscreenCanvas without rendering contexts. Spec change needs to be done later on. Meanwhile, this CL also fixed crash bug in the corner case when convertToBlob with webp image type fails. BUG=659260, 563830 Review-Url: https://codereview.chromium.org/2695343002 Cr-Commit-Position: refs/heads/master@{#452935} Committed: https://chromium.googlesource.com/chromium/src/+/5ce8692f118a0f554fa98574be0c5446b8f0b8fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -8 lines) Patch
M third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-convertToBlob-exceptions.html View 1 chunk +23 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp View 3 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
xlai (Olivia)
3 years, 10 months ago (2017-02-15 21:42:28 UTC) #3
xlai (Olivia)
gentle ping to junov@
3 years, 9 months ago (2017-02-24 17:17:22 UTC) #7
Justin Novosad
lgtm
3 years, 9 months ago (2017-02-24 18:31:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695343002/1
3 years, 9 months ago (2017-02-24 19:48:43 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-02-24 21:40:39 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5ce8692f118a0f554fa98574be0c...

Powered by Google App Engine
This is Rietveld 408576698