Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2695323002: [cleanup] NATIVE_CONTEXT_IMPORTED_FIELDS to NATIVE_CONTEXT_INTRINSIC_FUNCTIONS (Closed)

Created:
3 years, 10 months ago by caitp
Modified:
3 years, 10 months ago
Reviewers:
adamk, jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] NATIVE_CONTEXT_IMPORTED_FIELDS to NATIVE_CONTEXT_INTRINSIC_FUNCTIONS Some of these functions are invoked by BytecodeGenerator due to parser desugarings, and moving the context indices cause BytecodeExpectationsPrinter to render them as something useful/meaningful. BUG= R=jgruber@chromium.org, adamk@chromium.org Review-Url: https://codereview.chromium.org/2695323002 Cr-Commit-Position: refs/heads/master@{#43225} Committed: https://chromium.googlesource.com/v8/v8/+/c96a47deeffe409d150a5b0c75f8d2d2a64d86e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M src/contexts.h View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
caitp
PTAL. This is just to improve BytecodeExpectationsPrinter output for async functions (bytecode tests for these ...
3 years, 10 months ago (2017-02-15 20:35:50 UTC) #5
adamk
lgtm
3 years, 10 months ago (2017-02-15 21:23:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695323002/1
3 years, 10 months ago (2017-02-15 21:53:19 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/c96a47deeffe409d150a5b0c75f8d2d2a64d86e6
3 years, 10 months ago (2017-02-15 21:55:02 UTC) #11
jgruber
3 years, 10 months ago (2017-02-16 08:29:26 UTC) #12
Message was sent while issue was closed.
lgtm, thanks.

Powered by Google App Engine
This is Rietveld 408576698