Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2695313002: Resurect KioskCrashRestore browser test (Closed)

Created:
3 years, 10 months ago by tbarzic
Modified:
3 years, 10 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Resurect KioskCrashRestore browser test The test is still running on branches (and is currently broken, since the expectations have changed since 57) - adding it back so the test fix can be merged back. BUG=689100 Review-Url: https://codereview.chromium.org/2695313002 Cr-Commit-Position: refs/heads/master@{#451075} Committed: https://chromium.googlesource.com/chromium/src/+/ac9147c505a91add2903a1aca8a72f6ec3398dae

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : test fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -0 lines) Patch
A chrome/browser/chromeos/app_mode/kiosk_crash_restore_browsertest.cc View 2 1 chunk +200 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
tbarzic
Note- Patchset 2 contains previous browser test code.
3 years, 10 months ago (2017-02-16 00:11:06 UTC) #2
xiyuan
lgtm
3 years, 10 months ago (2017-02-16 00:23:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695313002/30001
3 years, 10 months ago (2017-02-16 00:25:09 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xcode-clang/builds/43681)
3 years, 10 months ago (2017-02-16 01:10:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695313002/30001
3 years, 10 months ago (2017-02-16 02:50:26 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/240628)
3 years, 10 months ago (2017-02-16 02:53:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695313002/30001
3 years, 10 months ago (2017-02-16 17:42:07 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 20:14:37 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:30001) as
https://chromium.googlesource.com/chromium/src/+/ac9147c505a91add2903a1aca8a7...

Powered by Google App Engine
This is Rietveld 408576698