Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2695283004: cros: md-oobe UI tweaks. (Closed)

Created:
3 years, 10 months ago by jdufault
Modified:
3 years, 10 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: md-oobe UI tweaks. Address first two items on bug: - Status bar is not greyed out. - Corner radius of the modal should be 4dp BUG=690725 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2695283004 Cr-Commit-Position: refs/heads/master@{#451026} Committed: https://chromium.googlesource.com/chromium/src/+/f08225136b6ad80d5ac4a86b2919d8b998f2fc66

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/login/oobe_dialog_host.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/screen_container.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
jdufault
alemate@ PTAL.
3 years, 10 months ago (2017-02-15 22:27:57 UTC) #5
Alexander Alekseev
lgtm
3 years, 10 months ago (2017-02-15 22:34:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695283004/1
3 years, 10 months ago (2017-02-15 22:45:06 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
3 years, 10 months ago (2017-02-16 00:32:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695283004/1
3 years, 10 months ago (2017-02-16 18:19:32 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 18:49:25 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f08225136b6ad80d5ac4a86b2919...

Powered by Google App Engine
This is Rietveld 408576698