Chromium Code Reviews Chromium Code Reviews
Issue 2695283003:
Convert MediaElementAudioSource tests to testharness. (Closed)
| Index: third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-wrapper.html |
| diff --git a/third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-wrapper.html b/third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-wrapper.html |
| index 359fbbb56701c0767816ffcc8ad4c2c7afb17d07..47077abaa4b0ff5908e6e05b540330d3ea8262a3 100644 |
| --- a/third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-wrapper.html |
| +++ b/third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-wrapper.html |
| @@ -1,28 +1,54 @@ |
| <!DOCTYPE html> |
| <html> |
| <head> |
| -<script src="../../resources/js-test.js"></script> |
| +<script src="../../resources/testharness.js"></script> |
| +<script src="../../resources/testharnessreport.js"></script> |
| <script src="../resources/audit-util.js"></script> |
| -<script src="../resources/audio-testing.js"></script> |
| +<script src="../resources/audit.js"></script> |
| </head> |
| <body> |
| <script> |
| -description("Verifies that for .mediaElement getters, a wrapper that corresponds to the actual element is created."); |
| - |
| -var source; |
| -function testMediaWrapper(kind) { |
| - var element = document.createElement(kind); |
| - var context = new AudioContext(); |
| - |
| - source = context.createMediaElementSource(element); |
| - element = context = null; |
| - gc(); |
| - shouldBeUndefined('source.mediaElement.nonExistentProperty'); |
| - source = null; |
| +let audit = Audit.createTaskRunner(); |
| + |
| +let source; |
|
hongchan
2017/02/24 23:32:26
Does this have to be global?
|
| + |
| +function testMediaWrapper(kind, should) { |
| + let element = document.createElement(kind); |
| + let context = new AudioContext(); |
| + |
| + source = context.createMediaElementSource(element); |
| + element = context = null; |
| + gc(); |
|
hongchan
2017/02/24 23:32:26
We need some gate logic when this test runs on the
|
| + |
| + should( |
| + source.mediaElement.nonExistentProperty === undefined, |
| + 'source.mediaElement.nonExistentProperty is undefined') |
| + .beTrue(); |
| + |
| + source = null; |
| } |
| -testMediaWrapper('audio'); |
| -testMediaWrapper('video'); |
| +audit.define( |
| + { |
| + label: 'audio', |
| + descrition: 'Verifies that audioElement getters are wrapped correctly' |
| + }, |
| + (task, should) => { |
| + testMediaWrapper('audio', should); |
| + task.done(); |
| + }); |
| + |
| +audit.define( |
| + { |
| + label: 'video', |
| + description: 'Verifies that videoElement getters are wrapped correctly' |
| + }, |
| + (task, should) => { |
| + testMediaWrapper('video', should); |
| + task.done(); |
| + }); |
| + |
| +audit.run(); |
| </script> |
| </body> |
| </html> |
