Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2695243003: Remove IsRunningOnIOS9OrLater() check from omnibox_text_field_ios (Closed)

Created:
3 years, 10 months ago by pkl (ping after 24h if needed)
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, jdonnelly+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove IsRunningOnIOS9OrLater() check from omnibox_text_field_ios iOS 9 is now the minimum supported OS version. BUG=633626 Review-Url: https://codereview.chromium.org/2695243003 Cr-Commit-Position: refs/heads/master@{#452154} Committed: https://chromium.googlesource.com/chromium/src/+/5d155163c0ffe96e22b9432fd6978bd7bcb9f15f

Patch Set 1 #

Patch Set 2 : remove .h as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm View 1 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
pkl (ping after 24h if needed)
3 years, 10 months ago (2017-02-16 15:19:54 UTC) #3
pkl (ping after 24h if needed)
3 years, 10 months ago (2017-02-16 15:21:39 UTC) #5
justincohen
lgtm
3 years, 10 months ago (2017-02-17 05:30:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695243003/20001
3 years, 10 months ago (2017-02-17 05:31:20 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/366966)
3 years, 10 months ago (2017-02-17 05:56:40 UTC) #10
pkl (ping after 24h if needed)
rohitrao: Needs OWNER l-g-t-m. PTAL. Thanks!
3 years, 10 months ago (2017-02-17 06:04:39 UTC) #11
pkl (ping after 24h if needed)
rohitrao: friendly ping!
3 years, 10 months ago (2017-02-22 15:12:42 UTC) #12
rohitrao (ping after 24h)
lgtm
3 years, 10 months ago (2017-02-22 18:38:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695243003/20001
3 years, 10 months ago (2017-02-22 18:50:08 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 19:09:30 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5d155163c0ffe96e22b9432fd697...

Powered by Google App Engine
This is Rietveld 408576698