Use IPC::TestSink instead of MockSubresourceFilterDrivers in unittests.

Use IPC::TestSink instead of MockSubresourceFilterDrivers in unittests.

Refactor ContentSubresourceFilterDriverFactoryTests to no longer inject mock
ContentSubresourceFilterDrivers for verifying that the sending of activation 
IPC messages is triggered.

Instead, expect to find the activation IPC message in the IPC::TestSink
associated with the MockRenderProcessHost. This supports unit-testing scenarios
with transfer navigations, without the need for inventing a mechanism to inject
mock drivers into all RFHs at opportune times.

BUG=637415
Review-Url: https://codereview.chromium.org/2695243002
Cr-Commit-Position: refs/heads/master@{#450695}
Committed: https://chromium.googlesource.com/chromium/src/+/5dbb827e3b41a97ec2d7105a0378c268a5d29fbe

[engedy, 2017-02-15 14:23:08]

Description was changed from

==========
Use IPC::TestSink instead of MockSubresourceFilterDrivers in unittests.

Refactor ContentSubresourceFilterDriverFactoryTest so that it no longer injects
a mock ContentSubresourceFilterDriver to verify that sending the activation IPC
message is triggered.

Instead, expect to find the activation IPC message in the IPC::TestSink
associated with the MockRenderProcessHost. This supports unit-testing scenarios
with transfer navigations, without the need to invent a cunning mechanism for
injecting mock drivers into all RFHs at opportunate times.

BUG=637415
==========

to

==========
Use IPC::TestSink instead of MockSubresourceFilterDrivers in unittests.

Refactor ContentSubresourceFilterDriverFactoryTests to no longer inject mock
ContentSubresourceFilterDrivers for verifying that the sending of activation 
IPC messages is triggered.

Instead, expect to find the activation IPC message in the IPC::TestSink
associated with the MockRenderProcessHost. This supports unit-testing scenarios
with transfer navigations, without the need for inventing a mechanism to inject
mock drivers into all RFHs at opportune times.

BUG=637415
==========

[engedy, 2017-02-15 14:23:08]

engedy@chromium.org changed reviewers:
+ melandory@chromium.org

[engedy, 2017-02-15 14:24:07]

Tanja, could you please take a quick look?

[engedy, 2017-02-15 14:24:11]

The CQ bit was checked by engedy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 14:24:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[melandory, 2017-02-15 14:26:35]

On 2017/02/15 14:24:07, engedy wrote:
> Tanja, could you please take a quick look?

this dark magic lgtm

[Charlie Harrison, 2017-02-15 14:28:07]

csharrison@chromium.org changed reviewers:
+ csharrison@chromium.org

[Charlie Harrison, 2017-02-15 14:28:08]

drive-by: Can you use the same trick for safe_browsing_service_browsertest.cc?
This would completely eliminate the driver as a "mockable IPC sender", and we
could just remove it in a followup.

[engedy, 2017-02-15 14:34:12]

The CQ bit was unchecked by engedy@chromium.org

[engedy, 2017-02-15 14:34:15]

The CQ bit was checked by engedy@chromium.org

[commit-bot: I haz the power, 2017-02-15 14:34:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[engedy, 2017-02-15 14:37:54]

On 2017/02/15 14:28:08, Charlie Harrison wrote:
> drive-by: Can you use the same trick for safe_browsing_service_browsertest.cc?
> This would completely eliminate the driver as a "mockable IPC sender", and we
> could just remove it in a followup.

Unfortunately that's an InProcessBrowserTest, so the TestSink trick won't work,
but I'm thinking about a different way to verify that the activation IPC was
sent in that case. Indeed, the ultimate goal is to remove the driver.

[commit-bot: I haz the power, 2017-02-15 14:54:19]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487169255627050, "parent_rev":
"d77ba4c9ecb5315db4dc26ac3f42ff767e94ae63", "commit_rev":
"5dbb827e3b41a97ec2d7105a0378c268a5d29fbe"}

[commit-bot: I haz the power, 2017-02-15 14:54:53]

Description was changed from

==========
Use IPC::TestSink instead of MockSubresourceFilterDrivers in unittests.

Refactor ContentSubresourceFilterDriverFactoryTests to no longer inject mock
ContentSubresourceFilterDrivers for verifying that the sending of activation 
IPC messages is triggered.

Instead, expect to find the activation IPC message in the IPC::TestSink
associated with the MockRenderProcessHost. This supports unit-testing scenarios
with transfer navigations, without the need for inventing a mechanism to inject
mock drivers into all RFHs at opportune times.

BUG=637415
==========

to

==========
Use IPC::TestSink instead of MockSubresourceFilterDrivers in unittests.

Refactor ContentSubresourceFilterDriverFactoryTests to no longer inject mock
ContentSubresourceFilterDrivers for verifying that the sending of activation 
IPC messages is triggered.

Instead, expect to find the activation IPC message in the IPC::TestSink
associated with the MockRenderProcessHost. This supports unit-testing scenarios
with transfer navigations, without the need for inventing a mechanism to inject
mock drivers into all RFHs at opportune times.

BUG=637415

Review-Url: https://codereview.chromium.org/2695243002
Cr-Commit-Position: refs/heads/master@{#450695}
Committed:
https://chromium.googlesource.com/chromium/src/+/5dbb827e3b41a97ec2d7105a0378...
==========

[commit-bot: I haz the power, 2017-02-15 14:54:54]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5dbb827e3b41a97ec2d7105a0378...

[Charlie Harrison, 2017-02-15 14:57:46]

SGTM for some reason I thought IPC sinks were compatible with browser tests.