Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2695233004: Implement PasswordStore::GetAllStats (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 1 week ago by jdoerrie
Modified:
3 months, 1 week ago
Reviewers:
vasilii
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement PasswordStore::GetAllStats In anticipation of the cleanup for obsolete HTTP data this change implements PasswordStore::GetAllStats as a convenient way to obtain statistics for all sites. BUG=687968 R=vasilii@chromium.org Review-Url: https://codereview.chromium.org/2695233004 Cr-Commit-Position: refs/heads/master@{#451298} Committed: https://chromium.googlesource.com/chromium/src/+/d467321ca5b51ba137007694a7cf4260392e6609

Patch Set 1 #

Patch Set 2 : Add Mac Implementations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -10 lines) Patch
M chrome/browser/password_manager/password_store_mac.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/password_manager/password_store_mac.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/password_manager/password_store_proxy_mac.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/password_manager/password_store_proxy_mac.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/mock_password_store.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/core/browser/password_store.h View 3 chunks +8 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_store.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_store_default.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/core/browser/password_store_default.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/statistics_table.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/statistics_table.cc View 3 chunks +24 lines, -10 lines 0 comments Download
M components/password_manager/core/browser/statistics_table_unittest.cc View 10 chunks +14 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/test_password_store.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/core/browser/test_password_store.cc View 1 chunk +4 lines, -0 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 20 (12 generated)
jdoerrie
Hi Vasilii, please have a look
3 months, 1 week ago (2017-02-16 14:49:46 UTC) #3
vasilii
lgtm
3 months, 1 week ago (2017-02-16 15:29:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695233004/1
3 months, 1 week ago (2017-02-16 15:39:12 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/389829)
3 months, 1 week ago (2017-02-16 16:14:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695233004/1
3 months, 1 week ago (2017-02-17 08:43:09 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/390570)
3 months, 1 week ago (2017-02-17 09:08:23 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695233004/20001
3 months, 1 week ago (2017-02-17 12:39:49 UTC) #17
commit-bot: I haz the power
3 months, 1 week ago (2017-02-17 14:11:41 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d467321ca5b51ba137007694a7cf...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06