Add PhysicalWebShareActivity

Add PhysicalWebShareActivity

This adds the PhysicalWebShareActivity, a empty-activity that will call
the PhysicalWebBroadcastService. It is invoked in the share intent
picker with the Physical Web logo, similiarly to the PrintShareActivity.

BUG=685856
Review-Url: https://codereview.chromium.org/2695163002
Cr-Commit-Position: refs/heads/master@{#451411}
Committed: https://chromium.googlesource.com/chromium/src/+/bb3232b44160a665e67c55d9c43b74794c963279

[iankc, 2017-02-14 23:30:09]

iankc@google.com changed reviewers:
+ mattreynolds@chromium.org

[iankc, 2017-02-14 23:30:09]

Hey Matt,

I got more work for you! Could you take a look at this before I send this to
Ted? Thanks

[mattreynolds, 2017-02-15 00:11:13]

lgtm

https://codereview.chromium.org/2695163002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(right):

https://codereview.chromium.org/2695163002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:1161:
List<Class<? extends Activity>> classesToEnable = new ArrayList<>(1);
Let's initialize with a capacity of 2 so it will never need to grow the
ArrayList.

https://codereview.chromium.org/2695163002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebShareActivity.java
(right):

https://codereview.chromium.org/2695163002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebShareActivity.java:1:
// Copyright 2016 The Chromium Authors. All rights reserved.
Happy new year! It's 2017!

[iankc, 2017-02-15 01:13:07]

iankc@google.com changed reviewers:
+ tedchoc@chromium.org

[iankc, 2017-02-15 01:13:07]

tedchoc@chromium.org: Please review changes in 

Hey Ted, where is adding the Physical Web Share Activity. It exactly like the
PrintShare Activity.

https://codereview.chromium.org/2695163002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(right):

https://codereview.chromium.org/2695163002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:1161:
List<Class<? extends Activity>> classesToEnable = new ArrayList<>(1);
On 2017/02/15 00:11:13, mattreynolds wrote:
> Let's initialize with a capacity of 2 so it will never need to grow the
> ArrayList.

Done.

https://codereview.chromium.org/2695163002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebShareActivity.java
(right):

https://codereview.chromium.org/2695163002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebShareActivity.java:1:
// Copyright 2016 The Chromium Authors. All rights reserved.
On 2017/02/15 00:11:13, mattreynolds wrote:
> Happy new year! It's 2017!

Done.

[Ted C, 2017-02-15 05:09:57]

lgtm

[iankc, 2017-02-15 17:17:07]

The CQ bit was checked by iankc@google.com

[iankc, 2017-02-15 17:17:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
mattreynolds@chromium.org
Link to the patchset: https://codereview.chromium.org/2695163002/#ps20001
(title: "Fixing Matts Nits 1")

[commit-bot: I haz the power, 2017-02-15 17:17:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 17:21:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 17:21:35]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[iankc, 2017-02-15 22:58:10]

The CQ bit was checked by iankc@google.com

[iankc, 2017-02-15 22:58:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, mattreynolds@chromium.org
Link to the patchset: https://codereview.chromium.org/2695163002/#ps40001
(title: "Rebasing with Master")

[commit-bot: I haz the power, 2017-02-15 22:58:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 01:00:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 01:00:58]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[iankc, 2017-02-17 00:11:24]

The CQ bit was checked by iankc@google.com

[iankc, 2017-02-17 00:11:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, mattreynolds@chromium.org
Link to the patchset: https://codereview.chromium.org/2695163002/#ps60001
(title: "rebasing")

[iankc, 2017-02-17 00:12:06]

The CQ bit was unchecked by iankc@google.com

[iankc, 2017-02-17 00:13:12]

The CQ bit was checked by iankc@google.com

[iankc, 2017-02-17 00:13:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, mattreynolds@chromium.org
Link to the patchset: https://codereview.chromium.org/2695163002/#ps80001
(title: "formatting")

[commit-bot: I haz the power, 2017-02-17 00:14:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 02:17:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 02:17:11]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[iankc, 2017-02-17 20:40:37]

The CQ bit was checked by iankc@google.com

[iankc, 2017-02-17 20:40:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, mattreynolds@chromium.org
Link to the patchset: https://codereview.chromium.org/2695163002/#ps100001
(title: "Rebasing Again")

[commit-bot: I haz the power, 2017-02-17 20:41:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 02:21:55]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1487364037133010,
"parent_rev": "28ad2a15159467d825c159b4f617b9f93383c725", "commit_rev":
"bb3232b44160a665e67c55d9c43b74794c963279"}

[commit-bot: I haz the power, 2017-02-18 02:22:58]

Description was changed from

==========
Add PhysicalWebShareActivity

This adds the PhysicalWebShareActivity, a empty-activity that will call
the PhysicalWebBroadcastService. It is invoked in the share intent
picker with the Physical Web logo, similiarly to the PrintShareActivity.

BUG=685856
==========

to

==========
Add PhysicalWebShareActivity

This adds the PhysicalWebShareActivity, a empty-activity that will call
the PhysicalWebBroadcastService. It is invoked in the share intent
picker with the Physical Web logo, similiarly to the PrintShareActivity.

BUG=685856

Review-Url: https://codereview.chromium.org/2695163002
Cr-Commit-Position: refs/heads/master@{#451411}
Committed:
https://chromium.googlesource.com/chromium/src/+/bb3232b44160a665e67c55d9c43b...
==========

[commit-bot: I haz the power, 2017-02-18 02:23:11]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/bb3232b44160a665e67c55d9c43b...