Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2695143003: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 10 months ago by ymzhang1
Modified:
3 years, 10 months ago
CC:
chromium-reviews, wfh+watch_chromium.org, blink-reviews, jam, abarth-chromium, feature-media-reviews_chromium.org, darin-cc_chromium.org, huangs+watch_chromium.org, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2695143003 Cr-Commit-Position: refs/heads/master@{#450783} Committed: https://chromium.googlesource.com/chromium/src/+/5a91761d5cf889ee6990230b3add84cc48f1022a

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove uncertain files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chrome/browser/speech/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/resources/media/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/speech/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/media/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M courgette/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M media/audio/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/webrtc_overrides/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 10 months ago (2017-02-14 23:35:40 UTC) #3
tommi (sloooow) - chröme
lgtm for parts where I'm an owner, but please get additional stamps for the two ...
3 years, 10 months ago (2017-02-15 16:29:52 UTC) #4
ymzhang1
On 2017/02/15 16:29:52, tommi (krómíum) wrote: > lgtm for parts where I'm an owner, but ...
3 years, 10 months ago (2017-02-15 18:03:29 UTC) #5
ymzhang1
3 years, 10 months ago (2017-02-15 18:03:55 UTC) #6
tommi (sloooow) - chröme
lgtm
3 years, 10 months ago (2017-02-15 18:24:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695143003/20001
3 years, 10 months ago (2017-02-15 18:37:22 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 19:55:21 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5a91761d5cf889ee6990230b3add...

Powered by Google App Engine
This is Rietveld 408576698