Password manager internals page service: wiring it in

components/password_manager/core/browser/log_router.h

Index: components/password_manager/core/browser/log_router.h
diff --git a/components/password_manager/core/browser/log_router.h b/components/password_manager/core/browser/log_router.h
index c7ab218e4951433fd37ea73a7b3a13b2d79e2a67..5da6601278d440f5a484207455bc3bdb336448e1 100644
--- a/components/password_manager/core/browser/log_router.h
+++ b/components/password_manager/core/browser/log_router.h
@@ -60,6 +60,14 @@ class LogRouter {
   // Logs accumulated since the first receiver was registered.
   std::string accumulated_logs_;
 
+#if !defined(NDEBUG)
+  // Only notify observes from |receivers_| if this is set to true. It will be

[Ilya Sherman, 2014/05/13 04:32:18]

nit: "observes" -> "observers"

[vabr (Chromium), 2014/05/13 09:27:11]

Gone -> done. :)

+  // set to false during adding a new receiver, because that might have been
+  // triggered from the receiver's constructor, and it's not a good idea to use
+  // classes which did not finish constructing themselves.
+  bool can_use_receivers_;
+#endif

[Ilya Sherman, 2014/05/13 04:32:18]

Hmm, why is this code debug-only?

[vabr (Chromium), 2014/05/13 09:27:11]

I was overzealous with trying to slim down the release code.
But that's all gone now.

+
   DISALLOW_COPY_AND_ASSIGN(LogRouter);
 };