Password manager internals page service: wiring it in

components/password_manager/core/browser/log_router.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_LOG_ROUTER_H_
 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_LOG_ROUTER_H_
 
 #include <set>
 #include <string>
 
@@ skipping 42 matching lines @@
  private:
   // Observer lists for clients and receivers. The |true| in the template
   // specialisation means that they will check that all observers were removed
   // on destruction.
   ObserverList<PasswordManagerClient, true> clients_;
   ObserverList<PasswordManagerLogger, true> receivers_;
 
   // Logs accumulated since the first receiver was registered.
   std::string accumulated_logs_;
 
+#if !defined(NDEBUG)
+  // Only notify observes from |receivers_| if this is set to true. It will be

[Ilya Sherman, 2014/05/13 04:32:18]

nit: "observes" -> "observers"

[vabr (Chromium), 2014/05/13 09:27:11]

Gone -> done. :)

+  // set to false during adding a new receiver, because that might have been
+  // triggered from the receiver's constructor, and it's not a good idea to use
+  // classes which did not finish constructing themselves.
+  bool can_use_receivers_;
+#endif

[Ilya Sherman, 2014/05/13 04:32:18]

Hmm, why is this code debug-only?

[vabr (Chromium), 2014/05/13 09:27:11]

I was overzealous with trying to slim down the release code.
But that's all gone now.

+
   DISALLOW_COPY_AND_ASSIGN(LogRouter);
 };
 
 }  // namespace password_manager
 
 #endif  // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_LOG_ROUTER_H_