Password manager internals page service: wiring it in

chrome/browser/password_manager/chrome_password_manager_client.h

Index: chrome/browser/password_manager/chrome_password_manager_client.h
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.h b/chrome/browser/password_manager/chrome_password_manager_client.h
index f57fc3b5652ae426c7f119945ea7a18b700c5dc7..18fb2f78e0eb06283693c024cb19e6c557cc6e0b 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.h
+++ b/chrome/browser/password_manager/chrome_password_manager_client.h
@@ -53,8 +53,7 @@ class ChromePasswordManagerClient
   virtual base::FieldTrial::Probability GetProbabilityForExperiment(
       const std::string& experiment_name) OVERRIDE;
   virtual bool IsPasswordSyncEnabled() OVERRIDE;
-  virtual void SetLogger(password_manager::PasswordManagerLogger* logger)
-      OVERRIDE;
+  virtual void NotifyCanUseLogRouter(bool router_can_be_used) OVERRIDE;
   virtual void LogSavePasswordProgress(const std::string& text) OVERRIDE;
   virtual bool IsLoggingActive() const OVERRIDE;
 
@@ -107,7 +106,7 @@ class ChromePasswordManagerClient
   void ShowPasswordEditingPopup(
       const gfx::RectF& bounds, const autofill::PasswordForm& form);
 
-  Profile* GetProfile();
+  Profile* const profile_;

[Ilya Sherman, 2014/05/13 04:32:18]

Hmm, why did you change the profile to be cached, rather than calling
web_contents()->GetProfile()?  Is that change important for this CL?

[vabr (Chromium), 2014/05/13 09:27:11]

Yes. The problem was: I needed the profile in the destructor, to unregister from
the service. But at that time the web_contents was already NULL (whereas the
Profile outlives this class). If there's a good way to access the profile in the
destructor, then I'm happy to use that and not introduce the caching. But I have
not found any.

 
   password_manager::ContentPasswordManagerDriver driver_;
 
@@ -121,10 +120,8 @@ class ChromePasswordManagerClient
   // Allows authentication callbacks to be destroyed when this client is gone.
   base::WeakPtrFactory<ChromePasswordManagerClient> weak_factory_;
 
-  // Points to an active logger instance to use for, e.g., reporting progress on
-  // saving passwords. If there is no active logger (most of the time), the
-  // pointer will be NULL.
-  password_manager::PasswordManagerLogger* logger_;
+  // True if |this| is registered with some LogRouter which can accept logs.
+  bool can_use_log_router_;
 
   DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient);
 };