Password manager internals page service: wiring it in

chrome/browser/password_manager/chrome_password_manager_client.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
 #define CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "components/password_manager/content/browser/content_password_manager_driver.h"
@@ skipping 35 matching lines @@
   virtual void PasswordAutofillWasBlocked(
       const autofill::PasswordFormMap& best_matches) const OVERRIDE;
   virtual void AuthenticateAutofillAndFillForm(
       scoped_ptr<autofill::PasswordFormFillData> fill_data) OVERRIDE;
   virtual PrefService* GetPrefs() OVERRIDE;
   virtual password_manager::PasswordStore* GetPasswordStore() OVERRIDE;
   virtual password_manager::PasswordManagerDriver* GetDriver() OVERRIDE;
   virtual base::FieldTrial::Probability GetProbabilityForExperiment(
       const std::string& experiment_name) OVERRIDE;
   virtual bool IsPasswordSyncEnabled() OVERRIDE;
-  virtual void SetLogger(password_manager::PasswordManagerLogger* logger)
-      OVERRIDE;
+  virtual void NotifyCanUseLogRouter(bool router_can_be_used) OVERRIDE;
   virtual void LogSavePasswordProgress(const std::string& text) OVERRIDE;
   virtual bool IsLoggingActive() const OVERRIDE;
 
   // Hides any visible generation UI.
   void HidePasswordGenerationPopup();
 
   static void CreateForWebContentsWithAutofillManagerDelegate(
       content::WebContents* contents,
       autofill::AutofillManagerDelegate* delegate);
 
@@ skipping 32 matching lines @@
   // The popup will be anchored at |element_bounds|. The generated password
   // will be no longer than |max_length|.
   void ShowPasswordGenerationPopup(const gfx::RectF& bounds,
                                    int max_length,
                                    const autofill::PasswordForm& form);
 
   // Causes the password editing UI to be shown anchored at |element_bounds|.
   void ShowPasswordEditingPopup(
       const gfx::RectF& bounds, const autofill::PasswordForm& form);
 
-  Profile* GetProfile();
+  Profile* const profile_;

[Ilya Sherman, 2014/05/13 04:32:18]

Hmm, why did you change the profile to be cached, rather than calling
web_contents()->GetProfile()?  Is that change important for this CL?

[vabr (Chromium), 2014/05/13 09:27:11]

Yes. The problem was: I needed the profile in the destructor, to unregister from
the service. But at that time the web_contents was already NULL (whereas the
Profile outlives this class). If there's a good way to access the profile in the
destructor, then I'm happy to use that and not introduce the caching. But I have
not found any.

 
   password_manager::ContentPasswordManagerDriver driver_;
 
   // Observer for password generation popup.
   autofill::PasswordGenerationPopupObserver* observer_;
 
   // Controls the popup
   base::WeakPtr<
     autofill::PasswordGenerationPopupControllerImpl> popup_controller_;
 
   // Allows authentication callbacks to be destroyed when this client is gone.
   base::WeakPtrFactory<ChromePasswordManagerClient> weak_factory_;
 
-  // Points to an active logger instance to use for, e.g., reporting progress on
-  // saving passwords. If there is no active logger (most of the time), the
-  // pointer will be NULL.
-  password_manager::PasswordManagerLogger* logger_;
+  // True if |this| is registered with some LogRouter which can accept logs.
+  bool can_use_log_router_;
 
   DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient);
 };
 
 #endif  // CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_