Keep the reference to local private variable.

Keep the reference to local private variable.

Applications create a printdocumentadapter using WebView.createPrintDocumentAdapter
and passes it to Android framework, which then drives the printing flow.
If an application cleans all the references to this WebView,
then it can be GC'ed before printing flow ends. During the print UI flow,
as the user changes settings, frameworks makes calls the printdocumentadapter
that is created above, and thus WebView being GC'ed is fatal, i.e. not an exception
but printing will fail.

To prevent WebView being GC'ed we keep a reference to the webview in
AwPdfExporter, as long as frameworks owns it. Enabling proguard
optimizations optimized away this local variable. Add an explicit keep.

BUG=664400
Review-Url: https://codereview.chromium.org/2695123005
Cr-Commit-Position: refs/heads/master@{#450618}
Committed: https://chromium.googlesource.com/chromium/src/+/5e06547be990aacac4ae3ff0382d2aa222b4280a

[sgurun-gerrit only, 2017-02-15 01:08:34]

Description was changed from

==========
Keep the reference to local private variable.

Applications create a printdocumentadapter using
WebView.createPrintDocumentAdapter
and passes it to Android framework, which then drives the printing flow.
If an application cleans all the references to this WebView,
then it can be GC'ed before printing flow ends. During the print UI flow,
as the user changes settings, frameworks makes calls the printdocumentadapter
that is created above, and thus WebView being GC'ed is fatal, i.e. not an
exception
but printing will fail.

To prevent WebView being GC'ed we keep a reference to the webview in
AwPdfExporter, as long as frameworks owns it. Enabling proguard
optimizations optimized away this local variable. Add an explicit keep.

BUG=664400
==========

to

==========
Keep the reference to local private variable.

Applications create a printdocumentadapter using
WebView.createPrintDocumentAdapter
and passes it to Android framework, which then drives the printing flow.
If an application cleans all the references to this WebView,
then it can be GC'ed before printing flow ends. During the print UI flow,
as the user changes settings, frameworks makes calls the printdocumentadapter
that is created above, and thus WebView being GC'ed is fatal, i.e. not an
exception
but printing will fail.

To prevent WebView being GC'ed we keep a reference to the webview in
AwPdfExporter, as long as frameworks owns it. Enabling proguard
optimizations optimized away this local variable. Add an explicit keep.

BUG=664400
==========

[sgurun-gerrit only, 2017-02-15 01:08:34]

sgurun@chromium.org changed reviewers:
+ paulmiller@chromium.org

[paulmiller, 2017-02-15 01:12:21]

On 2017/02/15 01:08:34, sgurun wrote:
> mailto:sgurun@chromium.org changed reviewers:
> + mailto:paulmiller@chromium.org

lgtm

[sgurun-gerrit only, 2017-02-15 02:54:29]

The CQ bit was checked by sgurun@chromium.org

[commit-bot: I haz the power, 2017-02-15 02:55:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 07:03:52]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487127269906160, "parent_rev":
"be7ca6f626d4d7c15e9924da2fe0d693840a3d11", "commit_rev":
"5e06547be990aacac4ae3ff0382d2aa222b4280a"}

[commit-bot: I haz the power, 2017-02-15 07:04:23]

Description was changed from

==========
Keep the reference to local private variable.

Applications create a printdocumentadapter using
WebView.createPrintDocumentAdapter
and passes it to Android framework, which then drives the printing flow.
If an application cleans all the references to this WebView,
then it can be GC'ed before printing flow ends. During the print UI flow,
as the user changes settings, frameworks makes calls the printdocumentadapter
that is created above, and thus WebView being GC'ed is fatal, i.e. not an
exception
but printing will fail.

To prevent WebView being GC'ed we keep a reference to the webview in
AwPdfExporter, as long as frameworks owns it. Enabling proguard
optimizations optimized away this local variable. Add an explicit keep.

BUG=664400
==========

to

==========
Keep the reference to local private variable.

Applications create a printdocumentadapter using
WebView.createPrintDocumentAdapter
and passes it to Android framework, which then drives the printing flow.
If an application cleans all the references to this WebView,
then it can be GC'ed before printing flow ends. During the print UI flow,
as the user changes settings, frameworks makes calls the printdocumentadapter
that is created above, and thus WebView being GC'ed is fatal, i.e. not an
exception
but printing will fail.

To prevent WebView being GC'ed we keep a reference to the webview in
AwPdfExporter, as long as frameworks owns it. Enabling proguard
optimizations optimized away this local variable. Add an explicit keep.

BUG=664400

Review-Url: https://codereview.chromium.org/2695123005
Cr-Commit-Position: refs/heads/master@{#450618}
Committed:
https://chromium.googlesource.com/chromium/src/+/5e06547be990aacac4ae3ff0382d...
==========

[commit-bot: I haz the power, 2017-02-15 07:04:24]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5e06547be990aacac4ae3ff0382d...