Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

Issue 2695113005: DevTools: Support regex and case sensitive search in Performance panel (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
index 50b719fd63c50bdf34562489ca0162caec790dd5..9e2245e9e0ed12f27648bfc8996a3803322d0e0d 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
@@ -383,7 +383,7 @@ Timeline.TimelineTreeView = class extends UI.VBox {
this._currentResult = 0;
if (!this._root)
return;
- var searchRegex = createPlainTextSearchRegex(searchConfig.query, 'i');
+ var searchRegex = searchConfig.toSearchRegex();
this._searchResults =
this._root.searchTree(event => Timeline.TimelineUIUtils.testContentMatching(event, searchRegex));
this._searchableView.updateSearchMatchesCount(this._searchResults.length);
@@ -414,7 +414,7 @@ Timeline.TimelineTreeView = class extends UI.VBox {
* @return {boolean}
*/
supportsCaseSensitiveSearch() {
- return false;
+ return true;
}
/**
@@ -422,7 +422,7 @@ Timeline.TimelineTreeView = class extends UI.VBox {
* @return {boolean}
*/
supportsRegexSearch() {
- return false;
+ return true;
}
};
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698