Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js

Issue 2695113005: DevTools: Support regex and case sensitive search in Performance panel (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js
index d7e69c7869246d5c21931c14ca8f7cf378ad3656..82fa8a691b6d9cfd3b87004b18ec2543331d37cf 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js
@@ -370,7 +370,7 @@ Timeline.TimelineFlameChartView = class extends UI.VBox {
* @return {boolean}
*/
supportsCaseSensitiveSearch() {
- return false;
+ return true;
}
/**
@@ -378,7 +378,7 @@ Timeline.TimelineFlameChartView = class extends UI.VBox {
* @return {boolean}
*/
supportsRegexSearch() {
- return false;
+ return true;
}
/**
@@ -469,8 +469,7 @@ Timeline.TimelineFlameChartView = class extends UI.VBox {
* @param {boolean=} jumpBackwards
*/
performSearch(searchConfig, shouldJump, jumpBackwards) {
- var query = searchConfig.query;
- this._searchRegex = createPlainTextSearchRegex(query, 'i');
+ this._searchRegex = searchConfig.toSearchRegex();
delete this._searchResults;
this._updateSearchHighlight(true, shouldJump, jumpBackwards);
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698