Convert StereoPanner Audit tests to testharness

Convert StereoPanner tests to testharness

The following script was used to convert the tests:

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(.*)\|finishJSTest()\);[ 	]*$/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
  # Remove expected results file.
  base=`basename $f .html`
  if [ -f $base-expected.txt ]; then
      git rm $base-expected.txt
  fi
done

Some manual adjustments needed in stereopanner-testing.js to replace
the calls to testPassed/testFailed.

stereopannernode-basic.html was converted by hand to use testharness
and new Audit.

BUG=688495
TEST=stereopannernode-no-glitch.html, stereopannernode-panning.html,
stereopannernode-basic.html

Review-Url: https://codereview.chromium.org/2695113003
Cr-Commit-Position: refs/heads/master@{#452146}
Committed: https://chromium.googlesource.com/chromium/src/+/b9ef335915c92ee0bc4d6cb6c69bf3d2be021621

[Raymond Toy, 2017-02-15 16:32:41]

Description was changed from

==========
Convert StereoPanner Audit tests to testharness

The following script was used to convert the tests:

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(.*)\|finishJSTest()\);[ 	]*$/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
  # Remove expected results file.
  base=`basename $f .html`
  if [ -f $base-expected.txt ]; then
      git rm $base-expected.txt
  fi
done

Some manual adjustments needed in stereopanner-testing.js to replace
the calls to testPassed/testFailed.

BUG=688495
TEST=stereopannernode-no-glitch.html, stereopannernode-panning.html
==========

to

==========
Convert StereoPanner tests to testharness

The following script was used to convert the tests:

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(.*)\|finishJSTest()\);[ 	]*$/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
  # Remove expected results file.
  base=`basename $f .html`
  if [ -f $base-expected.txt ]; then
      git rm $base-expected.txt
  fi
done

Some manual adjustments needed in stereopanner-testing.js to replace
the calls to testPassed/testFailed.

stereopannernode-basic.html was converted by hand to use testharness
and new Audit.

BUG=688495
TEST=stereopannernode-no-glitch.html, stereopannernode-panning.html,
stereopannernode-basic.html
==========

[Raymond Toy, 2017-02-15 16:33:51]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-02-15 16:33:52]

PTAL

[hongchan, 2017-02-17 18:36:19]

https://codereview.chromium.org/2695113003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-no-glitch.html
(right):

https://codereview.chromium.org/2695113003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-no-glitch.html:13:

I prefer to remove this empty line.

https://codereview.chromium.org/2695113003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-no-glitch.html:44:
// TODO(rtoy): Replace this
Not sure what this means. Replace how?

https://codereview.chromium.org/2695113003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-no-glitch.html:62:
//testPassed('Transition found between sample #' + start + ' and #' + end +
'.');
Commented out, so we should remove this before landing.

https://codereview.chromium.org/2695113003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-panning.html
(right):

https://codereview.chromium.org/2695113003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-panning.html:14:
<div id="console"></div>
These two lines need to be removed.

https://codereview.chromium.org/2695113003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/resources/stereopanner-testing.js
(right):

https://codereview.chromium.org/2695113003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/stereopanner-testing.js:179:
/*
Please remove commented out sections.

[Raymond Toy, 2017-02-17 19:18:41]

https://codereview.chromium.org/2695113003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-no-glitch.html
(right):

https://codereview.chromium.org/2695113003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-no-glitch.html:44:
// TODO(rtoy): Replace this
On 2017/02/17 18:36:19, hongchan wrote:
> Not sure what this means. Replace how?

Replaced with Should().summarize().

https://codereview.chromium.org/2695113003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-no-glitch.html:62:
//testPassed('Transition found between sample #' + start + ' and #' + end +
'.');
On 2017/02/17 18:36:19, hongchan wrote:
> Commented out, so we should remove this before landing.

Done.

https://codereview.chromium.org/2695113003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/resources/stereopanner-testing.js
(right):

https://codereview.chromium.org/2695113003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/stereopanner-testing.js:179:
/*
On 2017/02/17 18:36:19, hongchan wrote:
> Please remove commented out sections.

Done.

[hongchan, 2017-02-21 17:11:36]

lgtm with a nit

https://codereview.chromium.org/2695113003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-no-glitch.html
(right):

https://codereview.chromium.org/2695113003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-no-glitch.html:43:
// TODO(rtoy): Replace this
If this is replaced as you wanted, please remove the comment.

[Raymond Toy, 2017-02-21 17:41:54]

https://codereview.chromium.org/2695113003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-no-glitch.html
(right):

https://codereview.chromium.org/2695113003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-no-glitch.html:43:
// TODO(rtoy): Replace this
On 2017/02/21 17:11:36, hongchan wrote:
> If this is replaced as you wanted, please remove the comment.

Done.

[Raymond Toy, 2017-02-21 17:42:00]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2017-02-21 17:42:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2695113003/#ps60001
(title: "Address review comment")

[commit-bot: I haz the power, 2017-02-21 17:42:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 18:49:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 18:49:54]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Raymond Toy, 2017-02-21 21:27:13]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2017-02-21 21:27:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2695113003/#ps80001
(title: "Fix typo")

[commit-bot: I haz the power, 2017-02-21 21:28:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 23:31:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 23:31:30]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[Raymond Toy, 2017-02-22 18:21:40]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2017-02-22 18:22:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 18:49:25]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487787700961500,
"parent_rev": "454a93cffb64135a92ba1d8b282be7d1d45f07df", "commit_rev":
"b9ef335915c92ee0bc4d6cb6c69bf3d2be021621"}

[commit-bot: I haz the power, 2017-02-22 18:49:59]

Description was changed from

==========
Convert StereoPanner tests to testharness

The following script was used to convert the tests:

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(.*)\|finishJSTest()\);[ 	]*$/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
  # Remove expected results file.
  base=`basename $f .html`
  if [ -f $base-expected.txt ]; then
      git rm $base-expected.txt
  fi
done

Some manual adjustments needed in stereopanner-testing.js to replace
the calls to testPassed/testFailed.

stereopannernode-basic.html was converted by hand to use testharness
and new Audit.

BUG=688495
TEST=stereopannernode-no-glitch.html, stereopannernode-panning.html,
stereopannernode-basic.html
==========

to

==========
Convert StereoPanner tests to testharness

The following script was used to convert the tests:

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(.*)\|finishJSTest()\);[ 	]*$/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
  # Remove expected results file.
  base=`basename $f .html`
  if [ -f $base-expected.txt ]; then
      git rm $base-expected.txt
  fi
done

Some manual adjustments needed in stereopanner-testing.js to replace
the calls to testPassed/testFailed.

stereopannernode-basic.html was converted by hand to use testharness
and new Audit.

BUG=688495
TEST=stereopannernode-no-glitch.html, stereopannernode-panning.html,
stereopannernode-basic.html

Review-Url: https://codereview.chromium.org/2695113003
Cr-Commit-Position: refs/heads/master@{#452146}
Committed:
https://chromium.googlesource.com/chromium/src/+/b9ef335915c92ee0bc4d6cb6c69b...
==========

[commit-bot: I haz the power, 2017-02-22 18:50:00]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/b9ef335915c92ee0bc4d6cb6c69b...