Fix the position of context menu for BrowserPlugins inside OOPIF (Merge to M-57)

Fix the position of context menu for BrowserPlugins inside OOPIF (Merge to M-57)

Currently, we do not consider the displacement of OOPIF view on page when
update the geomtery of BrowserPluginGuest. This causes the context menu
offset (the displacement between WebContents's) to be wrong.

This CL will make the following changes to fix this issue:
1- The reported rect in OnUpdateGeometry() is transformed to owner view's
coordinate space.

2- We make sure BrowserPlugin does its own conversions using RenderWidget
of the local root containing the BrowserPlugin (as opposed to the RenderView
which seems wrong).

3- We make sure BrowserPlugin updates geometry when it is attached.

BUG=670433
NOTRY=TRUE
NOPRESUBMIT=TRUE

Review-Url: https://codereview.chromium.org/2544223002
Cr-Commit-Position: refs/heads/master@{#446448}
(cherry picked from commit aeddbee1c18102e37b5dc083c99a337e12afa759)

Review-Url: https://codereview.chromium.org/2695103003
Cr-Commit-Position: refs/branch-heads/2987@{#512}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/b4d8f2c9b39a7fc569beede339aff9f2520604cf

[EhsanK, 2017-02-14 20:48:11]

Description was changed from

==========
Fix the position of context menu for BrowserPlugins inside OOPIF (Merge to M-57)

Currently, we do not consider the displacement of OOPIF view on page when
update the geomtery of BrowserPluginGuest. This causes the context menu
offset (the displacement between WebContents's) to be wrong.

This CL will make the following changes to fix this issue:
1- The reported rect in OnUpdateGeometry() is transformed to owner view's
coordinate space.

2- We make sure BrowserPlugin does its own conversions using RenderWidget
of the local root containing the BrowserPlugin (as opposed to the RenderView
which seems wrong).

3- We make sure BrowserPlugin updates geometry when it is attached.

BUG=670433

Review-Url: https://codereview.chromium.org/2544223002
Cr-Commit-Position: refs/heads/master@{#446448}
(cherry picked from commit aeddbee1c18102e37b5dc083c99a337e12afa759)
==========

to

==========
Fix the position of context menu for BrowserPlugins inside OOPIF (Merge to M-57)

Currently, we do not consider the displacement of OOPIF view on page when
update the geomtery of BrowserPluginGuest. This causes the context menu
offset (the displacement between WebContents's) to be wrong.

This CL will make the following changes to fix this issue:
1- The reported rect in OnUpdateGeometry() is transformed to owner view's
coordinate space.

2- We make sure BrowserPlugin does its own conversions using RenderWidget
of the local root containing the BrowserPlugin (as opposed to the RenderView
which seems wrong).

3- We make sure BrowserPlugin updates geometry when it is attached.

BUG=670433
NOTRY=TRUE
NOPRESUBMIT=TRUE

Review-Url: https://codereview.chromium.org/2544223002
Cr-Commit-Position: refs/heads/master@{#446448}
(cherry picked from commit aeddbee1c18102e37b5dc083c99a337e12afa759)
==========

[EhsanK, 2017-02-14 20:48:31]

ekaramad@chromium.org changed reviewers:
+ creis@chromium.org

[EhsanK, 2017-02-14 20:48:32]

Charlie,

PTAL.

Thanks!

[EhsanK, 2017-02-14 21:03:07]

On 2017/02/14 20:48:32, EhsanK wrote:
> Charlie,
> 
> PTAL.
> 
> Thanks!

Compiled and tested both chrome and the test on Linux.

[EhsanK, 2017-02-14 22:15:31]

ekaramad@chromium.org changed reviewers:
+ alexmos@chromium.org

[EhsanK, 2017-02-14 22:15:31]

alexmos@chromium.org: Please review changes in 

Alex, I believe you are the owner for the test file. Thanks!

[Charlie Reis, 2017-02-14 23:21:23]

LGTM!  Alex is OOO, but I'm an owner of that file as well.

(Also, feel free to TBR owners for straightforward merges, unless there's
something specific you'd like reviewed.)

[EhsanK, 2017-02-14 23:22:19]

Thanks Charlie! Will do!

[EhsanK, 2017-02-14 23:22:24]

The CQ bit was checked by ekaramad@chromium.org

[commit-bot: I haz the power, 2017-02-14 23:23:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 23:24:56]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487114544968690, "parent_rev":
"9054032265d30a95ac8214d8e01b3b1842f4b4e6", "commit_rev":
"b4d8f2c9b39a7fc569beede339aff9f2520604cf"}

[commit-bot: I haz the power, 2017-02-14 23:25:39]

Description was changed from

==========
Fix the position of context menu for BrowserPlugins inside OOPIF (Merge to M-57)

Currently, we do not consider the displacement of OOPIF view on page when
update the geomtery of BrowserPluginGuest. This causes the context menu
offset (the displacement between WebContents's) to be wrong.

This CL will make the following changes to fix this issue:
1- The reported rect in OnUpdateGeometry() is transformed to owner view's
coordinate space.

2- We make sure BrowserPlugin does its own conversions using RenderWidget
of the local root containing the BrowserPlugin (as opposed to the RenderView
which seems wrong).

3- We make sure BrowserPlugin updates geometry when it is attached.

BUG=670433
NOTRY=TRUE
NOPRESUBMIT=TRUE

Review-Url: https://codereview.chromium.org/2544223002
Cr-Commit-Position: refs/heads/master@{#446448}
(cherry picked from commit aeddbee1c18102e37b5dc083c99a337e12afa759)
==========

to

==========
Fix the position of context menu for BrowserPlugins inside OOPIF (Merge to M-57)

Currently, we do not consider the displacement of OOPIF view on page when
update the geomtery of BrowserPluginGuest. This causes the context menu
offset (the displacement between WebContents's) to be wrong.

This CL will make the following changes to fix this issue:
1- The reported rect in OnUpdateGeometry() is transformed to owner view's
coordinate space.

2- We make sure BrowserPlugin does its own conversions using RenderWidget
of the local root containing the BrowserPlugin (as opposed to the RenderView
which seems wrong).

3- We make sure BrowserPlugin updates geometry when it is attached.

BUG=670433
NOTRY=TRUE
NOPRESUBMIT=TRUE

Review-Url: https://codereview.chromium.org/2544223002
Cr-Commit-Position: refs/heads/master@{#446448}
(cherry picked from commit aeddbee1c18102e37b5dc083c99a337e12afa759)

Review-Url: https://codereview.chromium.org/2695103003
Cr-Commit-Position: refs/branch-heads/2987@{#512}
Cr-Branched-From:
ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed:
https://chromium.googlesource.com/chromium/src/+/b4d8f2c9b39a7fc569beede339af...
==========

[commit-bot: I haz the power, 2017-02-14 23:25:40]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b4d8f2c9b39a7fc569beede339af...