Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2695093006: Remove one navigation layout test (Closed)

Created:
3 years, 10 months ago by clamy
Modified:
3 years, 10 months ago
Reviewers:
Nate Chapin, nasko
CC:
chromium-reviews, blink-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove one navigation layout test This CL removes http/tests/navigation/response204.html. This test checks that a 204 response on a browser-initiated navigation will not result in an extra item in the navigation history. This is better tested as content_browsertest, especially since it cannot be tested using a layout test when PlzNavigate is enabled (renderers are not made aware of a browser-initiated navigation resulting in a 204). BUG=689153 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2695093006 Cr-Commit-Position: refs/heads/master@{#451288} Committed: https://chromium.googlesource.com/chromium/src/+/0e60da02d2e136fa7cc20abf8858b00846cbd331

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -17 lines) Patch
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 1 chunk +26 lines, -0 lines 0 comments Download
A content/test/data/page204.html View 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/page204.html.mock-http-headers View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/navigation/response204.html View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/navigation/response204-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
clamy
@nasko, japhet: PTAL
3 years, 10 months ago (2017-02-16 17:37:45 UTC) #6
Nate Chapin
lgtm
3 years, 10 months ago (2017-02-16 17:42:43 UTC) #7
nasko
LGTM
3 years, 10 months ago (2017-02-16 17:48:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695093006/1
3 years, 10 months ago (2017-02-17 11:37:06 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 12:41:52 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0e60da02d2e136fa7cc20abf8858...

Powered by Google App Engine
This is Rietveld 408576698