content/browser/renderer_host/render_widget_host_view_android.h - Issue 2695093005: Remove RWHV::SetBounds() from the public API, and make comments clearer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.h

Issue 2695093005: Remove RWHV::SetBounds() from the public API, and make comments clearer.

Patch Set: Revert web_contents_sizer to its previous shenanigans (http://crbug.com/693953). Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_view_android.h

diff --git a/content/browser/renderer_host/render_widget_host_view_android.h b/content/browser/renderer_host/render_widget_host_view_android.h

index a52a7a11bf017240fc70a78489e27d96af3209c8..9d5bd5a1917d8c1b4e2673983cc03c111845034b 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.h

+++ b/content/browser/renderer_host/render_widget_host_view_android.h

@@ -86,7 +86,6 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid

void InitAsFullscreen(RenderWidgetHostView* reference_host_view) override;

RenderWidgetHost* GetRenderWidgetHost() const override;

void SetSize(const gfx::Size& size) override;

- void SetBounds(const gfx::Rect& rect) override;

gfx::Vector2dF GetLastScrollOffset() const override;

gfx::NativeView GetNativeView() const override;

gfx::NativeViewAccessible GetNativeViewAccessible() override;

@@ -99,6 +98,7 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid

gfx::Rect GetViewBounds() const override;

gfx::Size GetVisibleViewportSize() const override;

gfx::Size GetPhysicalBackingSize() const override;

+ void RequestTopLevelBoundsInScreen(const gfx::Rect& rect) override;

bool DoBrowserControlsShrinkBlinkSize() const override;

float GetTopControlsHeight() const override;

float GetBottomControlsHeight() const override;