Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_android.h

Issue 2695093005: Remove RWHV::SetBounds() from the public API, and make comments clearer.
Patch Set: Revert web_contents_sizer to its previous shenanigans (http://crbug.com/693953). Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_ANDROID_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_ANDROID_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_ANDROID_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_ANDROID_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 void Blur(); 79 void Blur();
80 80
81 // RenderWidgetHostView implementation. 81 // RenderWidgetHostView implementation.
82 bool OnMessageReceived(const IPC::Message& msg) override; 82 bool OnMessageReceived(const IPC::Message& msg) override;
83 void InitAsChild(gfx::NativeView parent_view) override; 83 void InitAsChild(gfx::NativeView parent_view) override;
84 void InitAsPopup(RenderWidgetHostView* parent_host_view, 84 void InitAsPopup(RenderWidgetHostView* parent_host_view,
85 const gfx::Rect& pos) override; 85 const gfx::Rect& pos) override;
86 void InitAsFullscreen(RenderWidgetHostView* reference_host_view) override; 86 void InitAsFullscreen(RenderWidgetHostView* reference_host_view) override;
87 RenderWidgetHost* GetRenderWidgetHost() const override; 87 RenderWidgetHost* GetRenderWidgetHost() const override;
88 void SetSize(const gfx::Size& size) override; 88 void SetSize(const gfx::Size& size) override;
89 void SetBounds(const gfx::Rect& rect) override;
90 gfx::Vector2dF GetLastScrollOffset() const override; 89 gfx::Vector2dF GetLastScrollOffset() const override;
91 gfx::NativeView GetNativeView() const override; 90 gfx::NativeView GetNativeView() const override;
92 gfx::NativeViewAccessible GetNativeViewAccessible() override; 91 gfx::NativeViewAccessible GetNativeViewAccessible() override;
93 void Focus() override; 92 void Focus() override;
94 bool HasFocus() const override; 93 bool HasFocus() const override;
95 bool IsSurfaceAvailableForCopy() const override; 94 bool IsSurfaceAvailableForCopy() const override;
96 void Show() override; 95 void Show() override;
97 void Hide() override; 96 void Hide() override;
98 bool IsShowing() override; 97 bool IsShowing() override;
99 gfx::Rect GetViewBounds() const override; 98 gfx::Rect GetViewBounds() const override;
100 gfx::Size GetVisibleViewportSize() const override; 99 gfx::Size GetVisibleViewportSize() const override;
101 gfx::Size GetPhysicalBackingSize() const override; 100 gfx::Size GetPhysicalBackingSize() const override;
101 void RequestTopLevelBoundsInScreen(const gfx::Rect& rect) override;
102 bool DoBrowserControlsShrinkBlinkSize() const override; 102 bool DoBrowserControlsShrinkBlinkSize() const override;
103 float GetTopControlsHeight() const override; 103 float GetTopControlsHeight() const override;
104 float GetBottomControlsHeight() const override; 104 float GetBottomControlsHeight() const override;
105 void UpdateCursor(const WebCursor& cursor) override; 105 void UpdateCursor(const WebCursor& cursor) override;
106 void SetIsLoading(bool is_loading) override; 106 void SetIsLoading(bool is_loading) override;
107 void FocusedNodeChanged(bool is_editable_node, 107 void FocusedNodeChanged(bool is_editable_node,
108 const gfx::Rect& node_bounds_in_screen) override; 108 const gfx::Rect& node_bounds_in_screen) override;
109 void RenderProcessGone(base::TerminationStatus status, 109 void RenderProcessGone(base::TerminationStatus status,
110 int error_code) override; 110 int error_code) override;
111 void Destroy() override; 111 void Destroy() override;
(...skipping 265 matching lines...) Expand 10 before | Expand all | Expand 10 after
377 gfx::Vector2dF last_scroll_offset_; 377 gfx::Vector2dF last_scroll_offset_;
378 378
379 base::WeakPtrFactory<RenderWidgetHostViewAndroid> weak_ptr_factory_; 379 base::WeakPtrFactory<RenderWidgetHostViewAndroid> weak_ptr_factory_;
380 380
381 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewAndroid); 381 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewAndroid);
382 }; 382 };
383 383
384 } // namespace content 384 } // namespace content
385 385
386 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_ANDROID_H_ 386 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_ANDROID_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698