Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: runtime/vm/object.cc

Issue 2695013003: Mark dart: libraries as not debuggable (by default) (Closed)
Patch Set: hausner review Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/tests/service/step_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.cc
diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc
index b8da11621e888fdcac9c668face1563ce1bfda2e..cbe17ae5d47a035b10c9b58916d465dc8f074d09 100644
--- a/runtime/vm/object.cc
+++ b/runtime/vm/object.cc
@@ -10805,7 +10805,17 @@ RawLibrary* Library::NewLibraryHelper(const String& url, bool import_core_lib) {
result.set_native_entry_symbol_resolver(NULL);
result.set_is_in_fullsnapshot(false);
result.StoreNonPointer(&result.raw_ptr()->corelib_imported_, true);
- result.set_debuggable(!dart_private_scheme);
+ if (dart_private_scheme) {
+ // Never debug dart:_ libraries.
+ result.set_debuggable(false);
+ } else if (dart_scheme) {
+ // Only debug dart: libraries if we have been requested to show invisible
+ // frames.
+ result.set_debuggable(FLAG_show_invisible_frames);
+ } else {
+ // Default to debuggable for all other libraries.
+ result.set_debuggable(true);
+ }
result.set_is_dart_scheme(dart_scheme);
result.StoreNonPointer(&result.raw_ptr()->load_state_,
RawLibrary::kAllocated);
« no previous file with comments | « runtime/observatory/tests/service/step_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698