Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 2695013003: Mark dart: libraries as not debuggable (by default) (Closed)

Created:
3 years, 10 months ago by Cutch
Modified:
3 years, 10 months ago
Reviewers:
devoncarew, rmacnak, hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Mark dart: libraries as not debuggable (by default) Overridable via the service protocol. BUG= R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/16622c474f21116f48c0d09c2a45373ed531c387

Patch Set 1 #

Patch Set 2 : hausner review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -3 lines) Patch
M runtime/observatory/tests/service/positive_token_pos_test.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/tests/service/regress_28443_test.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/tests/service/service_test_common.dart View 1 1 chunk +18 lines, -0 lines 0 comments Download
M runtime/observatory/tests/service/set_library_debuggable_test.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/step_test.dart View 1 1 chunk +4 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Cutch
3 years, 10 months ago (2017-02-14 15:01:43 UTC) #3
hausner
LGTM.
3 years, 10 months ago (2017-02-14 15:52:34 UTC) #5
hausner
LGTM again.
3 years, 10 months ago (2017-02-15 10:30:42 UTC) #6
Cutch
3 years, 10 months ago (2017-02-15 11:53:33 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
16622c474f21116f48c0d09c2a45373ed531c387 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698