Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Side by Side Diff: runtime/vm/object.cc

Issue 2695013003: Mark dart: libraries as not debuggable (by default) (Closed)
Patch Set: hausner review Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/observatory/tests/service/step_test.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/object.h" 5 #include "vm/object.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 #include "platform/assert.h" 8 #include "platform/assert.h"
9 #include "vm/assembler.h" 9 #include "vm/assembler.h"
10 #include "vm/become.h" 10 #include "vm/become.h"
(...skipping 10787 matching lines...) Expand 10 before | Expand all | Expand 10 after
10798 &result.raw_ptr()->patch_classes_, 10798 &result.raw_ptr()->patch_classes_,
10799 GrowableObjectArray::New(Object::empty_array(), Heap::kOld)); 10799 GrowableObjectArray::New(Object::empty_array(), Heap::kOld));
10800 result.StorePointer(&result.raw_ptr()->imports_, Object::empty_array().raw()); 10800 result.StorePointer(&result.raw_ptr()->imports_, Object::empty_array().raw());
10801 result.StorePointer(&result.raw_ptr()->exports_, Object::empty_array().raw()); 10801 result.StorePointer(&result.raw_ptr()->exports_, Object::empty_array().raw());
10802 result.StorePointer(&result.raw_ptr()->loaded_scripts_, Array::null()); 10802 result.StorePointer(&result.raw_ptr()->loaded_scripts_, Array::null());
10803 result.StorePointer(&result.raw_ptr()->load_error_, Instance::null()); 10803 result.StorePointer(&result.raw_ptr()->load_error_, Instance::null());
10804 result.set_native_entry_resolver(NULL); 10804 result.set_native_entry_resolver(NULL);
10805 result.set_native_entry_symbol_resolver(NULL); 10805 result.set_native_entry_symbol_resolver(NULL);
10806 result.set_is_in_fullsnapshot(false); 10806 result.set_is_in_fullsnapshot(false);
10807 result.StoreNonPointer(&result.raw_ptr()->corelib_imported_, true); 10807 result.StoreNonPointer(&result.raw_ptr()->corelib_imported_, true);
10808 result.set_debuggable(!dart_private_scheme); 10808 if (dart_private_scheme) {
10809 // Never debug dart:_ libraries.
10810 result.set_debuggable(false);
10811 } else if (dart_scheme) {
10812 // Only debug dart: libraries if we have been requested to show invisible
10813 // frames.
10814 result.set_debuggable(FLAG_show_invisible_frames);
10815 } else {
10816 // Default to debuggable for all other libraries.
10817 result.set_debuggable(true);
10818 }
10809 result.set_is_dart_scheme(dart_scheme); 10819 result.set_is_dart_scheme(dart_scheme);
10810 result.StoreNonPointer(&result.raw_ptr()->load_state_, 10820 result.StoreNonPointer(&result.raw_ptr()->load_state_,
10811 RawLibrary::kAllocated); 10821 RawLibrary::kAllocated);
10812 result.StoreNonPointer(&result.raw_ptr()->index_, -1); 10822 result.StoreNonPointer(&result.raw_ptr()->index_, -1);
10813 const intptr_t kInitialNameCacheSize = 64; 10823 const intptr_t kInitialNameCacheSize = 64;
10814 result.InitResolvedNamesCache(kInitialNameCacheSize); 10824 result.InitResolvedNamesCache(kInitialNameCacheSize);
10815 result.InitClassDictionary(); 10825 result.InitClassDictionary();
10816 result.InitImportList(); 10826 result.InitImportList();
10817 result.AllocatePrivateKey(); 10827 result.AllocatePrivateKey();
10818 if (import_core_lib) { 10828 if (import_core_lib) {
(...skipping 12030 matching lines...) Expand 10 before | Expand all | Expand 10 after
22849 return UserTag::null(); 22859 return UserTag::null();
22850 } 22860 }
22851 22861
22852 22862
22853 const char* UserTag::ToCString() const { 22863 const char* UserTag::ToCString() const {
22854 const String& tag_label = String::Handle(label()); 22864 const String& tag_label = String::Handle(label());
22855 return tag_label.ToCString(); 22865 return tag_label.ToCString();
22856 } 22866 }
22857 22867
22858 } // namespace dart 22868 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/observatory/tests/service/step_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698