Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1528)

Issue 2694983002: Implement getType method in ChromeFileProvider (Closed)

Created:
3 years, 10 months ago by ssid
Modified:
3 years, 10 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement getType method in ChromeFileProvider Some apps do not assume that the uri provided is file type. So, when the binder tries to get the uri type, getType should be called with the file uri instead of the pseudo blocked file uri. BUG=690469 Review-Url: https://codereview.chromium.org/2694983002 Cr-Commit-Position: refs/heads/master@{#450396} Committed: https://chromium.googlesource.com/chromium/src/+/1f2e38edd1f5c21f9c52fb7d718ec87dc9b0b8e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/util/ChromeFileProvider.java View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
ssid
ptal, thanks
3 years, 10 months ago (2017-02-14 06:36:51 UTC) #2
Ted C
lgtm!
3 years, 10 months ago (2017-02-14 16:53:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694983002/1
3 years, 10 months ago (2017-02-14 17:34:57 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 17:39:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1f2e38edd1f5c21f9c52fb7d718e...

Powered by Google App Engine
This is Rietveld 408576698