Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2694963002: Revert of Reland v4 of Session refactor (Closed)

Created:
3 years, 10 months ago by Nicolas Zea
Modified:
3 years, 10 months ago
Reviewers:
skym, Patrick Noland
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland v4 of Session refactor (patchset #3 id:40001 of https://codereview.chromium.org/2683263002/ ) Reason for revert: Still crashing. Likely due to sync nodes being reused across windows not being handled gracefully. Original issue's description: > Reland v4 of Session refactor > > Previous review: https://codereview.chromium.org/2651583006/ > > Changes from previous review: > - Deletes sync tab nodes with invalid tab ids > - Adds support for gracefully ignoring tabs with the same tab id. It's > unclear how this might happen, but we now log an error and silently > ignore the tab, instead of crashing. > - Adds some more checks to tests > > TEST=SessionsSyncManagerTest.DuplicateTabIdFromNative, SessionsSyncManagerTest.MergeDeletesCorruptTabNodeId > BUG=639009 > > Review-Url: https://codereview.chromium.org/2683263002 > Cr-Commit-Position: refs/heads/master@{#449677} > Committed: https://chromium.googlesource.com/chromium/src/+/9e83363531256aad94ed2bec676bbca8d715fbe1 TBR=skym@chromium.org,pnoland@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=639009 Review-Url: https://codereview.chromium.org/2694963002 Cr-Commit-Position: refs/heads/master@{#450231} Committed: https://chromium.googlesource.com/chromium/src/+/471807b6e3af01f221c48a2b96b8156763ca1db1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1107 lines, -1459 lines) Patch
M chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc View 38 chunks +221 lines, -457 lines 0 comments Download
M components/sync_sessions/sessions_sync_manager.h View 7 chunks +61 lines, -6 lines 0 comments Download
M components/sync_sessions/sessions_sync_manager.cc View 28 chunks +224 lines, -241 lines 0 comments Download
M components/sync_sessions/synced_session_tracker.h View 7 chunks +45 lines, -91 lines 0 comments Download
M components/sync_sessions/synced_session_tracker.cc View 11 chunks +53 lines, -129 lines 0 comments Download
M components/sync_sessions/synced_session_tracker_unittest.cc View 11 chunks +160 lines, -295 lines 0 comments Download
M components/sync_sessions/tab_node_pool.h View 4 chunks +78 lines, -34 lines 0 comments Download
M components/sync_sessions/tab_node_pool.cc View 4 chunks +100 lines, -77 lines 0 comments Download
M components/sync_sessions/tab_node_pool_unittest.cc View 4 chunks +165 lines, -129 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Nicolas Zea
Created Revert of Reland v4 of Session refactor
3 years, 10 months ago (2017-02-14 02:13:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694963002/1
3 years, 10 months ago (2017-02-14 02:14:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/471807b6e3af01f221c48a2b96b8156763ca1db1
3 years, 10 months ago (2017-02-14 04:00:33 UTC) #6
skym
3 years, 10 months ago (2017-02-14 18:01:07 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698