Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2694933004: [d8] Call Isolate::Dispose also on early exit via quit() (Closed)

Created:
3 years, 10 months ago by Clemens Hammacher
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[d8] Call Isolate::Dispose also on early exit via quit() Isolate::Dispose calls i::Isolate::TearDown, which again calls i::Isolate::DumpAndResetCompilationStats. We need this to be called on each exit path for dumping runtime call stats. R=cbruni@chromium.org, bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2694933004 Cr-Commit-Position: refs/heads/master@{#43215} Committed: https://chromium.googlesource.com/v8/v8/+/3fc10464e16d058dd7a637da6ebe37d5005b5d78

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M src/d8.cc View 3 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Camillo Bruni
lgtm
3 years, 10 months ago (2017-02-15 13:28:51 UTC) #3
Clemens Hammacher
3 years, 10 months ago (2017-02-15 13:31:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694933004/1
3 years, 10 months ago (2017-02-15 14:28:11 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 14:29:33 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/3fc10464e16d058dd7a637da6ebe37d5005...

Powered by Google App Engine
This is Rietveld 408576698