Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: ui/views/controls/menu/menu_item_view.cc

Issue 2694903010: AX checked state changes (Closed)
Patch Set: Test checkbox attribute in automation API, fix whitespace, remove change to third party code Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/menu/menu_item_view.cc
diff --git a/ui/views/controls/menu/menu_item_view.cc b/ui/views/controls/menu/menu_item_view.cc
index 450cf5ac36534dc54c3bc2a45efa8cae66f045bb..fa3d9ee0d03f856e6f3c8809ed249a2301e6060b 100644
--- a/ui/views/controls/menu/menu_item_view.cc
+++ b/ui/views/controls/menu/menu_item_view.cc
@@ -174,10 +174,12 @@ void MenuItemView::GetAccessibleNodeData(ui::AXNodeData* node_data) {
node_data->AddStateFlag(ui::AX_STATE_HASPOPUP);
break;
case CHECKBOX:
- case RADIO:
- if (GetDelegate()->IsItemChecked(GetCommand()))
- node_data->AddStateFlag(ui::AX_STATE_CHECKED);
- break;
+ case RADIO: {
+ const bool isChecked = GetDelegate()->IsItemChecked(GetCommand());
dmazzoni 2017/03/09 19:33:41 is_checked
+ const int checkedState =
dmazzoni 2017/03/09 19:33:41 checked_state Also type AXCheckedState
aleventhal 2017/03/09 21:40:49 Done.
+ isChecked ? ui::AX_CHECKED_STATE_TRUE : ui::AX_CHECKED_STATE_FALSE;
+ node_data->AddIntAttribute(ui::AX_ATTR_CHECKED_STATE, checkedState);
+ } break;
case NORMAL:
case SEPARATOR:
case EMPTY:
« ui/views/controls/button/toggle_button.cc ('K') | « ui/views/controls/button/toggle_button.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698