AX checked state changes

ui/views/controls/menu/menu_item_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/menu/menu_item_view.h"
 
 #include <stddef.h>
 
 #include "base/i18n/case_conversion.h"
 #include "base/macros.h"
@@ skipping 156 matching lines @@
   } else {
     item_text = title_;
   }
   node_data->SetName(GetAccessibleNameForMenuItem(item_text, GetMinorText()));
 
   switch (GetType()) {
     case SUBMENU:
       node_data->AddStateFlag(ui::AX_STATE_HASPOPUP);
       break;
     case CHECKBOX:
-    case RADIO:
-      if (GetDelegate()->IsItemChecked(GetCommand()))
-        node_data->AddStateFlag(ui::AX_STATE_CHECKED);
-      break;
+    case RADIO: {
+      const bool isChecked = GetDelegate()->IsItemChecked(GetCommand());

[dmazzoni, 2017/03/09 19:33:41]

is_checked

+      const int checkedState =

[dmazzoni, 2017/03/09 19:33:41]

checked_state

Also type AXCheckedState

[aleventhal, 2017/03/09 21:40:49]

Done.

+          isChecked ? ui::AX_CHECKED_STATE_TRUE : ui::AX_CHECKED_STATE_FALSE;
+      node_data->AddIntAttribute(ui::AX_ATTR_CHECKED_STATE, checkedState);
+    } break;
     case NORMAL:
     case SEPARATOR:
     case EMPTY:
       // No additional accessibility states currently for these menu states.
       break;
   }
 }
 
 // static
 bool MenuItemView::IsBubble(MenuAnchorPosition anchor) {
@@ skipping 875 matching lines @@
     } else {
       const Type& type = menu_item->GetType();
       if (type == CHECKBOX || type == RADIO)
         return true;
     }
   }
   return false;
 }
 
 }  // namespace views