Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: third_party/WebKit/Source/web/WebAXObject.cpp

Issue 2694903010: AX checked state changes (Closed)
Patch Set: Test checkbox attribute in automation API, fix whitespace, remove change to third party code Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebAXObject.cpp
diff --git a/third_party/WebKit/Source/web/WebAXObject.cpp b/third_party/WebKit/Source/web/WebAXObject.cpp
index 648e6c624d90e3a9db877baece686ddc15769a87..878716913eba3e64c954bb504490b0957f6d9f20 100644
--- a/third_party/WebKit/Source/web/WebAXObject.cpp
+++ b/third_party/WebKit/Source/web/WebAXObject.cpp
@@ -281,18 +281,15 @@ WebAXAriaCurrentState WebAXObject::ariaCurrentState() const {
return static_cast<WebAXAriaCurrentState>(m_private->ariaCurrentState());
}
-bool WebAXObject::isButtonStateMixed() const {
- if (isDetached())
- return false;
-
- return m_private->checkboxOrRadioValue() == ButtonStateMixed;
+bool WebAXObject::isCheckable() const {
+ return !isDetached() && m_private->isCheckable();
}
-bool WebAXObject::isChecked() const {
+WebAXCheckedState WebAXObject::checkedState() const {
if (isDetached())
- return false;
+ return WebAXCheckedFalse;
- return m_private->isChecked();
+ return static_cast<WebAXCheckedState>(m_private->checkedState());
}
bool WebAXObject::isClickable() const {

Powered by Google App Engine
This is Rietveld 408576698