third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp - Issue 2694903010: AX checked state changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp

Issue 2694903010: AX checked state changes (Closed)

Patch Set: Test checkbox attribute in automation API, fix whitespace, remove change to third party code Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/accessibility/input-mixed.html ('K') | « third_party/WebKit/Source/modules/accessibility/AXObject.cpp ('k') | third_party/WebKit/Source/web/WebAXObject.cpp » ('j') | ui/views/controls/button/toggle_button.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp b/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp

index 96bd1fbfad9b562626c5029c78d56f30bb328a46..a7d05ecb55674f3f5f51ad64661d7d60866f840c 100644

--- a/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp

@@ -252,7 +252,7 @@ void fillWidgetStates(AXObject& axObject,

protocol::Array<AXProperty>& properties) {

AccessibilityRole role = axObject.roleValue();

if (roleAllowsChecked(role)) {

- AccessibilityButtonState checked = axObject.checkboxOrRadioValue();

+ AccessibilityButtonState checked = axObject.checkedState();

switch (checked) {

case ButtonStateOff:

properties.addItem(