chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js - Issue 2694903010: AX checked state changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

Issue 2694903010: AX checked state changes (Closed)

Patch Set: Fix compiler error Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/common/system/chromeos/ime_menu/ime_menu_tray_unittest.cc ('K') | « ash/common/system/tray/hover_highlight_view.cc ('k') | chrome/common/extensions/api/automation.idl » ('j') | third_party/WebKit/Source/web/WebAXObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

index 45720681c6992464733303b54d62854abd3e0f93..5f1d6f305e6616edbf5a27a1b144d95c57e9b35e 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

@@ -1155,20 +1155,16 @@ Output.prototype = {

}

} else if (token == 'checked') {

var msg;

- var ariaChecked = node.htmlAttributes['aria-checked'];

- switch (ariaChecked) {

+ switch (node.checked) {

case 'mixed':

msg = 'aria_checked_mixed';

break;

case 'true':

msg = 'aria_checked_true';

break;

- case 'false':

+ default:

msg = 'aria_checked_false';

break;

- default:

- msg = node.state[StateType.CHECKED] ?

- 'aria_checked_true' : 'aria_checked_false';

}

this.format_(node, '@' + msg, buff);

} else if (token == 'state') {