Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Issue 2694903003: Handle basic navigation controls without webcontents in VR Shell. (Closed)

Created:
3 years, 10 months ago by mthiesse
Modified:
3 years, 10 months ago
Reviewers:
bshe, cjgrant
CC:
chromium-reviews, feature-vr-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle basic navigation controls without webcontents in VR Shell. BUG=661609 Review-Url: https://codereview.chromium.org/2694903003 Cr-Commit-Position: refs/heads/master@{#450395} Committed: https://chromium.googlesource.com/chromium/src/+/cb8b0ad6f72ce2b0127b45362fa24b1721676cbc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -30 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java View 3 chunks +25 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell.cc View 2 chunks +29 lines, -30 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mthiesse
PTAL
3 years, 10 months ago (2017-02-14 16:14:29 UTC) #2
bshe
On 2017/02/14 16:14:29, mthiesse wrote: > PTAL lgtm
3 years, 10 months ago (2017-02-14 16:46:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694903003/1
3 years, 10 months ago (2017-02-14 16:49:36 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 17:29:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cb8b0ad6f72ce2b0127b45362fa2...

Powered by Google App Engine
This is Rietveld 408576698