Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2694863002:
MD Settings: Smart lock dialog is missing. (Closed)
|
Created:
3 years, 10 months ago by sammiequon Modified:
3 years, 10 months ago CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: Smart lock dialog is missing.
No text on MD settings easy unlock turn off dialog.
TEST=browser_tests --gtest_filter="SettingsEasyUnlockBrowserTest.*"
BUG=690745
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2694863002
Cr-Commit-Position: refs/heads/master@{#450469}
Committed: https://chromium.googlesource.com/chromium/src/+/140eee5b6a807d78fba47f180340a47d8ebc17ee
Patch Set 1 #
Total comments: 2
Patch Set 2 : Added tests. #
Messages
Total messages: 21 (11 generated)
Description was changed from ========== MD Settings: Smart lock dialog is missing. No text on MD settings easy unlock turn off dialog. TEST=manual BUG=690745 ========== to ========== MD Settings: Smart lock dialog is missing. No text on MD settings easy unlock turn off dialog. TEST=manual BUG=690745 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== MD Settings: Smart lock dialog is missing. No text on MD settings easy unlock turn off dialog. TEST=manual BUG=690745 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Smart lock dialog is missing. No text on MD settings easy unlock turn off dialog. TEST=manual BUG=690745 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
sammiequon@chromium.org changed reviewers: + tommycli@chromium.org
tommycli@ - Please take a look. Thanks!
lgtm thanks
On 2017/02/13 18:48:18, tommycli wrote: > lgtm thanks Thanks!
The CQ bit was checked by sammiequon@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by dbeam@chromium.org
dbeam@chromium.org changed reviewers: + dbeam@chromium.org
https://codereview.chromium.org/2694863002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.html (right): https://codereview.chromium.org/2694863002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.html:19: <div class="button-container" hidden="[[isButtonBarHidden_(status_)]]"> can we add a test that verifies whether the button bar is hidden to prevent future regressions like this?
Description was changed from ========== MD Settings: Smart lock dialog is missing. No text on MD settings easy unlock turn off dialog. TEST=manual BUG=690745 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Smart lock dialog is missing. No text on MD settings easy unlock turn off dialog. TEST=browser_tests --gtest_filter="SettingsEasyUnlockBrowserTest.*" BUG=690745 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
https://codereview.chromium.org/2694863002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.html (right): https://codereview.chromium.org/2694863002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.html:19: <div class="button-container" hidden="[[isButtonBarHidden_(status_)]]"> On 2017/02/13 19:55:00, Dan Beam wrote: > can we add a test that verifies whether the button bar is hidden to prevent > future regressions like this? Done.
lgtm, thanks for the test!
On 2017/02/14 05:34:35, Dan Beam wrote: > lgtm, thanks for the test! Thanks!
The CQ bit was checked by sammiequon@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tommycli@chromium.org Link to the patchset: https://codereview.chromium.org/2694863002/#ps20001 (title: "Added tests.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487101590734870,
"parent_rev": "5cbba721b07114d34c83086486bf9f4e5f69b5f2", "commit_rev":
"140eee5b6a807d78fba47f180340a47d8ebc17ee"}
Message was sent while issue was closed.
Description was changed from ========== MD Settings: Smart lock dialog is missing. No text on MD settings easy unlock turn off dialog. TEST=browser_tests --gtest_filter="SettingsEasyUnlockBrowserTest.*" BUG=690745 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Smart lock dialog is missing. No text on MD settings easy unlock turn off dialog. TEST=browser_tests --gtest_filter="SettingsEasyUnlockBrowserTest.*" BUG=690745 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2694863002 Cr-Commit-Position: refs/heads/master@{#450469} Committed: https://chromium.googlesource.com/chromium/src/+/140eee5b6a807d78fba47f180340... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/140eee5b6a807d78fba47f180340... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
