Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2694833003: Revert of Tag CSP violation reports as CSP reports, not as ping (Closed)

Created:
3 years, 10 months ago by xlai (Olivia)
Modified:
3 years, 10 months ago
Reviewers:
Mike West, Devlin, esprehn, robwu
CC:
blink-reviews, chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, gavinp+loader_chromium.org, Nate Chapin, loading-reviews_chromium.org, tyoshino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Tag CSP violation reports as CSP reports, not as ping (patchset #2 id:20001 of https://codereview.chromium.org/2402233002/ ) Reason for revert: Suspecting CL that cause virtual/stable/http/tests/navigation/image-load-in-unload-handler.html to fail on WebKit Linux Trusty ASAN: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20ASAN/builds/1117 Original issue's description: > Tag CSP violation reports as CSP reports, not as ping > > BUG=637577 > TEST=./browser_tests --gtest_filter=ExtensionWebRequestApiTest.WebRequestTypes > > Review-Url: https://codereview.chromium.org/2402233002 > Cr-Commit-Position: refs/heads/master@{#450329} > Committed: https://chromium.googlesource.com/chromium/src/+/ac2c8350c76da73e48d8ed582c85fd8f572b54d5 TBR=esprehn@chromium.org,mkwst@chromium.org,rdevlin.cronin@chromium.org,rob@robwu.nl # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=637577 Review-Url: https://codereview.chromium.org/2694833003 Cr-Commit-Position: refs/heads/master@{#450366} Committed: https://chromium.googlesource.com/chromium/src/+/226d1bedd1dd5ccc7b2c8a67c72470a4c88d179d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -107 lines) Patch
D chrome/test/data/extensions/api_test/webrequest/csp/violation.html View 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/test/data/extensions/api_test/webrequest/csp/violation.html.mock-http-headers View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/webrequest/test_types.js View 2 chunks +0 lines, -96 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api_helpers.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M extensions/common/api/web_request.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/PingLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
xlai (Olivia)
Created Revert of Tag CSP violation reports as CSP reports, not as ping
3 years, 10 months ago (2017-02-14 15:44:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694833003/1
3 years, 10 months ago (2017-02-14 15:45:07 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 15:48:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/226d1bedd1dd5ccc7b2c8a67c724...

Powered by Google App Engine
This is Rietveld 408576698