Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2694833002: Fix wording in in chrome_device_policy.proto comment (Closed)

Created:
3 years, 10 months ago by pmarko
Modified:
3 years, 10 months ago
Reviewers:
Thiemo Nagel
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix wording in in chrome_device_policy.proto comment Correct usage of "login page" to "login screen" in comment. See comments on crrev.com/2652793003. BUG=none Review-Url: https://codereview.chromium.org/2694833002 Cr-Commit-Position: refs/heads/master@{#450028} Committed: https://chromium.googlesource.com/chromium/src/+/30f4e173006200d594a3c4675c5bf7e09be4d1d4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/chromeos/policy/proto/chrome_device_policy.proto View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
pmarko
3 years, 10 months ago (2017-02-13 17:50:18 UTC) #2
Thiemo Nagel
LGTM.
3 years, 10 months ago (2017-02-13 17:54:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694833002/1
3 years, 10 months ago (2017-02-13 17:57:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/30f4e173006200d594a3c4675c5bf7e09be4d1d4
3 years, 10 months ago (2017-02-13 18:41:55 UTC) #8
Thiemo Nagel
3 years, 10 months ago (2017-02-14 11:00:11 UTC) #9
Message was sent while issue was closed.
I've got some more comments via
https://critique.corp.google.com/#review/147328399.

Could you please document what are valid locales and input methods?

Powered by Google App Engine
This is Rietveld 408576698