Revert of Make FrameSelection to hold non-canonicalized positions

Revert of Make FrameSelection to hold non-canonicalized positions (patchset #9 id:180001 of https://codereview.chromium.org/2680943004/ )

Reason for revert:
This patch looks like it is causing failures in editing/execCommand/move-up-down-should-skip-hidden-elements.html on Windows 7 (https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29).

Original issue's description:
> Make FrameSelection to hold non-canonicalized DOM positions
> 
> This patch makes |FrameSelection| to hold non-canonicalized DOM positions in
> |SelectionEditor| to align Selection API specification[1] for improving
> interoperatbility[2].
> 
> Before this patch we holds selection as |VisibleSelection| as canonicalized
> DOM positions. This behavior is not align with Selection API specification[1]
> then the most complained issue of Blink from editing-tf@w3c.
> 
> The heart of this patch is holding selection as |SelectionInDOMTree| and
> compute |VisibleSelection| on-demand with cache of computed |VisibleSelection|.
> 
> |VisibleSelection| cache is invalidate each DOM tree change and style change
> since canonicalization referes CSS style properties, e.g display, visibility,
> -webkit-user-modify, etc, and layout dimension.
> 
> |SelectionEditor| utilizes |SynchronousMutationObserver| to relocate
> |m_selectionInDOMTree| instead of |FrameSelection|. Before this patch
> |FrameSelection| relocates |VisibleSelection| with dirty layout tree then
> sets |FrameSelection::setSelection()|. To void cyclic reference between
> |FrameSelection| and |SelectionEditor|, we could not move relocation part to
> |SelectionEditor|.
> 
> This patch also updates 
> |FrameSelection::updatePostionAfterAdoptingTextNodesMerged()| to handle
> |PositonAnchorType|.
> 
> # Highlight of changes
> ## FrameCaret
> - Compute caret position after "layout clean" rather than each selection change
> to align rendering pipeline.
> 
> ## CharacterData
> Changes timing of notifying character data update for ease of relocation of
> positions.
> 
> ## FrameSelection
> - Move |m_isHandleVisible| to |SelectionInDOMTree| as follow-up of [5].
> - Move selection relocation to |SelectionEditor|; following patch will move
> implementations to "SelectionEditor.cpp"
> 
> ## SelecitonEdtior
> - Make it to hold |SelectionInDOMTree| with relocation at DOM mutation.
> - Caching |VisibleSelection|
> 
> # Brief description of test expectation changes:
> ## ImeTest.java:
> This patch gets rid of redundant selection change event from
>  - |testImePaste|,
>  - |testContentEditableEvents_DeleteSurroundingText|
>  - |testInputTextEvents_DeleteSurroundingText|
> 
> ## LayoutTests
> Before this patch, Blink uses |VisibleSelection| when it sets even if style and
> layout changed. This is wrong and unexpected behavior since positions in
> |VisibleSelection| can no longer be canonicalized positions. This patch changes
> this behavior to return "sane" canonicalized positions with clean style and
> layout tree.
> 
> This patch is the result of many attempts. Previous changes can be found in
> [3][4].
> 
> [1] https://www.w3.org/TR/selection-api/ W3C Selection API
> [2] https://goo.gl/9v1zOK Improving Interoperatbility of Selection
> [3] http://crrev.com/1958093002
> [4] http://crrev.com/2637013002
> [5] http://crrev.com/2651803007 Added isHandleVisible to |SelectionTemplate|
> 
> BUG=139552, 603684, 605499, 606499, 625533, 644648, 679991
> TEST=See changes in this patch
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Review-Url: https://codereview.chromium.org/2680943004
> Cr-Commit-Position: refs/heads/master@{#449928}
> Committed: https://chromium.googlesource.com/chromium/src/+/157413286770a7ac5a24c446a30c08f749738276

TBR=tkent@chromium.org,changwan@chromium.org,xiaochengh@chromium.org,yoichio@chromium.org,yosin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=139552, 603684, 605499, 606499, 625533, 644648, 679991
Review-Url: https://codereview.chromium.org/2694823002
Cr-Commit-Position: refs/heads/master@{#450018}
Committed: https://chromium.googlesource.com/chromium/src/+/47591962f15392d4af5eb1f69f3b79a8e2990947

[Garrett Casto, 2017-02-13 17:32:36]

The CQ bit was checked by gcasto@chromium.org

[Garrett Casto, 2017-02-13 17:32:37]

Created Revert of Make FrameSelection to hold non-canonicalized positions

[commit-bot: I haz the power, 2017-02-13 17:33:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 17:38:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 17:38:51]

Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/LayoutTests/TestExpectations:757
  error: third_party/WebKit/LayoutTests/TestExpectations: patch does not apply

Patch:       third_party/WebKit/LayoutTests/TestExpectations
Index: third_party/WebKit/LayoutTests/TestExpectations
diff --git a/third_party/WebKit/LayoutTests/TestExpectations
b/third_party/WebKit/LayoutTests/TestExpectations
index
3440bfcc63ab146a7b50a1d068aa9600ff78eaba..68c2e464f606191d04d442a3f485f454849a9ada
100644
--- a/third_party/WebKit/LayoutTests/TestExpectations
+++ b/third_party/WebKit/LayoutTests/TestExpectations
@@ -757,8 +757,6 @@
 crbug.com/563265 editing/spelling/spellcheck-editable-on-focus-multiframe.html
[ Skip ]
 crbug.com/563265 editing/spelling/spellcheck-editable-on-focus-sync.html [ Skip
]
 
-crbug.com/625533 paint/selection/selection-drag-image-in-iframe.html  [
NeedsRebaseline ]
-
 crbug.com/657946 [ Mac ]
virtual/color_space/fast/canvas/color-space/display_linear-rgb.html [ Failure ]
 crbug.com/671048 [ Linux Win ]
virtual/color_space/fast/canvas/color-space/display_linear-rgb.html [ Failure ]

[Garrett Casto, 2017-02-13 18:22:33]

The CQ bit was checked by gcasto@chromium.org

[commit-bot: I haz the power, 2017-02-13 18:23:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 18:26:01]

CQ is committing da patch.

Bot data: {"patchset_id": 290001, "attempt_start_ts": 1487010153642620,
"parent_rev": "ffd9fb25d65c80160879eb47bfc5d1b0fdfff57f", "commit_rev":
"47591962f15392d4af5eb1f69f3b79a8e2990947"}

[commit-bot: I haz the power, 2017-02-13 18:26:43]

Description was changed from

==========
Revert of Make FrameSelection to hold non-canonicalized positions (patchset #9
id:180001 of https://codereview.chromium.org/2680943004/ )

Reason for revert:
This patch looks like it is causing failures in
editing/execCommand/move-up-down-should-skip-hidden-elements.html on Windows 7
(https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7...).

Original issue's description:
> Make FrameSelection to hold non-canonicalized DOM positions
> 
> This patch makes |FrameSelection| to hold non-canonicalized DOM positions in
> |SelectionEditor| to align Selection API specification[1] for improving
> interoperatbility[2].
> 
> Before this patch we holds selection as |VisibleSelection| as canonicalized
> DOM positions. This behavior is not align with Selection API specification[1]
> then the most complained issue of Blink from editing-tf@w3c.
> 
> The heart of this patch is holding selection as |SelectionInDOMTree| and
> compute |VisibleSelection| on-demand with cache of computed
|VisibleSelection|.
> 
> |VisibleSelection| cache is invalidate each DOM tree change and style change
> since canonicalization referes CSS style properties, e.g display, visibility,
> -webkit-user-modify, etc, and layout dimension.
> 
> |SelectionEditor| utilizes |SynchronousMutationObserver| to relocate
> |m_selectionInDOMTree| instead of |FrameSelection|. Before this patch
> |FrameSelection| relocates |VisibleSelection| with dirty layout tree then
> sets |FrameSelection::setSelection()|. To void cyclic reference between
> |FrameSelection| and |SelectionEditor|, we could not move relocation part to
> |SelectionEditor|.
> 
> This patch also updates 
> |FrameSelection::updatePostionAfterAdoptingTextNodesMerged()| to handle
> |PositonAnchorType|.
> 
> # Highlight of changes
> ## FrameCaret
> - Compute caret position after "layout clean" rather than each selection
change
> to align rendering pipeline.
> 
> ## CharacterData
> Changes timing of notifying character data update for ease of relocation of
> positions.
> 
> ## FrameSelection
> - Move |m_isHandleVisible| to |SelectionInDOMTree| as follow-up of [5].
> - Move selection relocation to |SelectionEditor|; following patch will move
> implementations to "SelectionEditor.cpp"
> 
> ## SelecitonEdtior
> - Make it to hold |SelectionInDOMTree| with relocation at DOM mutation.
> - Caching |VisibleSelection|
> 
> # Brief description of test expectation changes:
> ## ImeTest.java:
> This patch gets rid of redundant selection change event from
>  - |testImePaste|,
>  - |testContentEditableEvents_DeleteSurroundingText|
>  - |testInputTextEvents_DeleteSurroundingText|
> 
> ## LayoutTests
> Before this patch, Blink uses |VisibleSelection| when it sets even if style
and
> layout changed. This is wrong and unexpected behavior since positions in
> |VisibleSelection| can no longer be canonicalized positions. This patch
changes
> this behavior to return "sane" canonicalized positions with clean style and
> layout tree.
> 
> This patch is the result of many attempts. Previous changes can be found in
> [3][4].
> 
> [1] https://www.w3.org/TR/selection-api/ W3C Selection API
> [2] https://goo.gl/9v1zOK Improving Interoperatbility of Selection
> [3] http://crrev.com/1958093002
> [4] http://crrev.com/2637013002
> [5] http://crrev.com/2651803007 Added isHandleVisible to |SelectionTemplate|
> 
> BUG=139552, 603684, 605499, 606499, 625533, 644648, 679991
> TEST=See changes in this patch
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Review-Url: https://codereview.chromium.org/2680943004
> Cr-Commit-Position: refs/heads/master@{#449928}
> Committed:
https://chromium.googlesource.com/chromium/src/+/157413286770a7ac5a24c446a30c...

TBR=tkent@chromium.org,changwan@chromium.org,xiaochengh@chromium.org,yoichio@...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=139552, 603684, 605499, 606499, 625533, 644648, 679991
==========

to

==========
Revert of Make FrameSelection to hold non-canonicalized positions (patchset #9
id:180001 of https://codereview.chromium.org/2680943004/ )

Reason for revert:
This patch looks like it is causing failures in
editing/execCommand/move-up-down-should-skip-hidden-elements.html on Windows 7
(https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7...).

Original issue's description:
> Make FrameSelection to hold non-canonicalized DOM positions
> 
> This patch makes |FrameSelection| to hold non-canonicalized DOM positions in
> |SelectionEditor| to align Selection API specification[1] for improving
> interoperatbility[2].
> 
> Before this patch we holds selection as |VisibleSelection| as canonicalized
> DOM positions. This behavior is not align with Selection API specification[1]
> then the most complained issue of Blink from editing-tf@w3c.
> 
> The heart of this patch is holding selection as |SelectionInDOMTree| and
> compute |VisibleSelection| on-demand with cache of computed
|VisibleSelection|.
> 
> |VisibleSelection| cache is invalidate each DOM tree change and style change
> since canonicalization referes CSS style properties, e.g display, visibility,
> -webkit-user-modify, etc, and layout dimension.
> 
> |SelectionEditor| utilizes |SynchronousMutationObserver| to relocate
> |m_selectionInDOMTree| instead of |FrameSelection|. Before this patch
> |FrameSelection| relocates |VisibleSelection| with dirty layout tree then
> sets |FrameSelection::setSelection()|. To void cyclic reference between
> |FrameSelection| and |SelectionEditor|, we could not move relocation part to
> |SelectionEditor|.
> 
> This patch also updates 
> |FrameSelection::updatePostionAfterAdoptingTextNodesMerged()| to handle
> |PositonAnchorType|.
> 
> # Highlight of changes
> ## FrameCaret
> - Compute caret position after "layout clean" rather than each selection
change
> to align rendering pipeline.
> 
> ## CharacterData
> Changes timing of notifying character data update for ease of relocation of
> positions.
> 
> ## FrameSelection
> - Move |m_isHandleVisible| to |SelectionInDOMTree| as follow-up of [5].
> - Move selection relocation to |SelectionEditor|; following patch will move
> implementations to "SelectionEditor.cpp"
> 
> ## SelecitonEdtior
> - Make it to hold |SelectionInDOMTree| with relocation at DOM mutation.
> - Caching |VisibleSelection|
> 
> # Brief description of test expectation changes:
> ## ImeTest.java:
> This patch gets rid of redundant selection change event from
>  - |testImePaste|,
>  - |testContentEditableEvents_DeleteSurroundingText|
>  - |testInputTextEvents_DeleteSurroundingText|
> 
> ## LayoutTests
> Before this patch, Blink uses |VisibleSelection| when it sets even if style
and
> layout changed. This is wrong and unexpected behavior since positions in
> |VisibleSelection| can no longer be canonicalized positions. This patch
changes
> this behavior to return "sane" canonicalized positions with clean style and
> layout tree.
> 
> This patch is the result of many attempts. Previous changes can be found in
> [3][4].
> 
> [1] https://www.w3.org/TR/selection-api/ W3C Selection API
> [2] https://goo.gl/9v1zOK Improving Interoperatbility of Selection
> [3] http://crrev.com/1958093002
> [4] http://crrev.com/2637013002
> [5] http://crrev.com/2651803007 Added isHandleVisible to |SelectionTemplate|
> 
> BUG=139552, 603684, 605499, 606499, 625533, 644648, 679991
> TEST=See changes in this patch
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Review-Url: https://codereview.chromium.org/2680943004
> Cr-Commit-Position: refs/heads/master@{#449928}
> Committed:
https://chromium.googlesource.com/chromium/src/+/157413286770a7ac5a24c446a30c...

TBR=tkent@chromium.org,changwan@chromium.org,xiaochengh@chromium.org,yoichio@...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=139552, 603684, 605499, 606499, 625533, 644648, 679991

Review-Url: https://codereview.chromium.org/2694823002
Cr-Commit-Position: refs/heads/master@{#450018}
Committed:
https://chromium.googlesource.com/chromium/src/+/47591962f15392d4af5eb1f69f3b...
==========

[commit-bot: I haz the power, 2017-02-13 18:26:45]

Committed patchset #2 (id:290001) as
https://chromium.googlesource.com/chromium/src/+/47591962f15392d4af5eb1f69f3b...

[tkent, 2017-02-13 22:56:25]

On 2017/02/13 at 18:26:45, commit-bot wrote:
> Committed patchset #2 (id:290001) as
https://chromium.googlesource.com/chromium/src/+/47591962f15392d4af5eb1f69f3b...

lgtm

Probably,
[ Debug ] editing/execCommand/move-up-down-should-skip-hidden-elements.html [
Slow ]

was enough. On Mac, the test took 4-5 sec before the culprit CL, and it took
12-17 sec after the CL.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...