Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2694813005: Revert of Remove header dependencies from sequence_checker.h to sequenced_worker_pool.h (Closed)

Created:
3 years, 10 months ago by Garrett Casto
Modified:
3 years, 10 months ago
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove header dependencies from sequence_checker.h to sequenced_worker_pool.h (patchset #6 id:470001 of https://codereview.chromium.org/2690533002/ ) Reason for revert: This patch is causing failures on the CrOS build bot: ../../chrome/browser/chromeos/login/wizard_controller.cc:225:42: error: member access into incomplete type 'base::SequencedWorkerPool' DCHECK(BrowserThread::GetBlockingPool()->RunsTasksOnCurrentThread()); ^ ../../base/threading/thread_restrictions.h:93:7: note: forward declaration of 'base::SequencedWorkerPool' class SequencedWorkerPool; ^ 1 error generated. Original issue's description: > Remove header dependencies from sequence_checker.h to sequenced_worker_pool.h > > This CL removes #include to sequenced_worker_pool.h in sequence_checker.h > by hiding its members into a nested class, and adds #include and forward > decls to other files as needed. > > Note that the non trivial diffs are in sequence_checker_impl.{h,cc} only. > > The header dependency from sequence_checker.h to sequenced_worker_pool.h > prevents other headers to use sequence_checker.h due to a dependency > cycle. > > TBR=sky@chromium.org, kinuko@chromium.org, rdsmith@chromium.org, qinmin@chromium.org, marq@chromium.org, rockot@chromium.org, blundell@chromium.org, oshima@chromium.org, slan@chromium.org, boliu@chromium.org > > Review-Url: https://codereview.chromium.org/2690533002 > Cr-Original-Commit-Position: refs/heads/master@{#450321} > Committed: https://chromium.googlesource.com/chromium/src/+/d502a3f2fa0b673a5082c1d601298bd114a9d237 > Review-Url: https://codereview.chromium.org/2690533002 > Cr-Commit-Position: refs/heads/master@{#450384} > Committed: https://chromium.googlesource.com/chromium/src/+/70b7c5d796420107930c72d4ad82e0c850166b1a TBR=gab@chromium.org,sky@chromium.org,kinuko@chromium.org,rdsmith@chromium.org,qinmin@chromium.org,marq@chromium.org,rockot@chromium.org,blundell@chromium.org,oshima@chromium.org,slan@chromium.org,boliu@chromium.org,msramek@chromium.org,tzik@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2694813005 Cr-Commit-Position: refs/heads/master@{#450402} Committed: https://chromium.googlesource.com/chromium/src/+/72c70c9d1f6b5453aeb518610b2fa581bed511aa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -290 lines) Patch
M android_webview/native/aw_metrics_service_client_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/system/tray/system_tray_notifier.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/wm_shell.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/mus/window_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/mus/window_manager_application.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shell.cc View 1 chunk +0 lines, -1 line 0 comments Download
M base/sequence_checker_impl.h View 2 chunks +16 lines, -4 lines 0 comments Download
M base/sequence_checker_impl.cc View 1 chunk +36 lines, -47 lines 0 comments Download
M base/test/launcher/test_launcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/logo_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/metrics/uma_session_stats.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/offline_pages/offline_page_model_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/offline_pages/offline_page_request_job.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/offline_pages/request_coordinator_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/shortcut_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/webapps/add_to_homescreen_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/apps/drive/drive_service_bridge.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/budget_service/budget_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/captive_portal/captive_portal_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/arc/arc_service_launcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/arc/process/arc_process_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/base/file_flusher_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/customization/customization_wallpaper_downloader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/external_metrics.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/snapshot_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_syncer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/dm_token_storage.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/system_log_uploader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/system_logs/debug_log_writer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/system_logs/touch_log_source_ozone.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/component_updater/ev_whitelist_component_installer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/component_updater/sth_set_component_installer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/crash_upload_list/crash_upload_list.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/downgrade/user_data_downgrade.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/downgrade/user_data_downgrade_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/download/download_commands.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/image_writer_private/write_from_url_operation_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/api/management/management_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/managed_value_store_cache.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_gcm_app_handler_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/updater/local_extension_cache.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/favicon/large_icon_service_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/gcm/gcm_profile_service_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/gcm/gcm_profile_service_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/loader/chrome_resource_dispatcher_host_delegate_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media/webrtc/desktop_media_list_ash.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media/webrtc/webrtc_log_list.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/memory_details.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/memory_details_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/memory_details_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/memory_details_mac.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/memory_details_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/metrics/plugin_metrics_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/metrics/variations/chrome_variations_service_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/dns_probe_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/errorpage_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/file_downloader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/file_downloader_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/net/url_request_mock_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ntp_snippets/content_suggestions_service_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ntp_tiles/chrome_popular_sites_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/platform_util_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/policy/cloud/test_request_interceptor.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_test_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/print_job.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_extension_message_filter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/module_load_analyzer_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/local_database_manager.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/local_database_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ssl/security_state_tab_helper_browser_tests.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/supervised_user/experimental/supervised_user_blacklist.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/supervised_user/legacy/supervised_user_registration_utility.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_site_list.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_url_filter.h View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/register_app_task_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_context.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_context.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_task_token.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/task_manager/sampling/shared_sampler_win_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/task_manager/sampling/task_manager_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/themes/theme_service_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_test_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/ash_init.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_screenshot_grabber.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_list.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/desktop_ios_promotion/sms_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/search/new_tab_page_interceptor_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/elevation_icon_setter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/taskbar_decorator_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/image_source.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_loader_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/printer_backend_proxy.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/printer_backend_proxy_chromeos.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/printer_capabilities.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/printer_capabilities_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/web_applications/web_app_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/win/enumerate_modules_model.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/chromedriver/net/sync_websocket_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/browser/metrics/external_metrics.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chromecast/browser/url_request_context_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/login/auth/login_performer.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chromeos/tpm/tpm_token_info_getter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/tpm/tpm_token_loader.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/browsing_data/content/conditional_cache_counting_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/db_data_owner.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/grpc_support/bidirectional_stream.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/history/core/browser/expire_history_backend.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/history/core/browser/web_history_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/memory_pressure/memory_pressure_monitor_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/ntp_tiles/popular_sites_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/ntp_tiles/popular_sites_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/password_manager/core/browser/affiliation_backend.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/policy/core/common/cloud/device_management_service.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/quirks/quirks_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/quirks/quirks_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/safe_browsing_db/v4_local_database_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sessions/core/base_session_service.h View 1 chunk +1 line, -1 line 0 comments Download
M components/storage_monitor/test_volume_mount_watcher_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/storage_monitor/volume_mount_watcher_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/variations/service/variations_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/web_restrictions/browser/web_restrictions_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/blob_storage/blob_storage_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/dom_storage/dom_storage_context_wrapper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/download/download_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/download/drag_download_file_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/url_loader_factory_impl_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/net/quota_policy_cookie_store.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/push_messaging/push_messaging_router.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/service_worker/embedded_worker_registry.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_database.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_request_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_unregister_job.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/tracing/tracing_controller_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/fileapi/webfilewriter_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/test/test_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_descriptor_win.h View 1 chunk +0 lines, -4 lines 0 comments Download
M device/usb/usb_device_android.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/browser/api/api_resource_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/browser/content_hash_fetcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/content_hash_fetcher_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/content_verify_job.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/updater/update_client_config.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/user_script_loader.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/renderer/extension_frame_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/application_context_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/google/google_logo_service.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/metrics/ios_chrome_metrics_service_client.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/net/chrome_cookie_store_ios_client.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/net/cookie_util.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ntp_tiles/ios_most_visited_sites_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ntp_tiles/ios_popular_sites_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/snapshots/snapshot_cache_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/suggestions/ios_image_decoder_impl_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/browser_view_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/first_run/first_run_util.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/omnibox/omnibox_popup_view_ios.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/web_resource/web_resource_util_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/today_extension/today_metrics_logger.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/shell/shell_url_request_context_getter.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/web_state/web_state_impl.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/web_view/internal/criwv_url_request_context_getter.mm View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/android/media_drm_bridge.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/android/http_auth_negotiate_android.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/proxy/dhcp_proxy_script_fetcher_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/ssl/channel_id_service.h View 1 chunk +4 lines, -1 line 0 comments Download
M services/service_manager/runner/host/service_process_launcher_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M services/service_manager/standalone/context.h View 1 chunk +0 lines, -1 line 0 comments Download
M storage/browser/blob/blob_data_handle.h View 1 chunk +0 lines, -1 line 0 comments Download
M storage/browser/quota/quota_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/accessibility/platform/atk_util_auralinux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/ime/input_method_chromeos.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/snapshot/snapshot_android.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Garrett Casto
Created Revert of Remove header dependencies from sequence_checker.h to sequenced_worker_pool.h
3 years, 10 months ago (2017-02-14 18:01:21 UTC) #2
Garrett Casto
On 2017/02/14 18:01:21, Garrett Casto wrote: > Created Revert of Remove header dependencies from sequence_checker.h ...
3 years, 10 months ago (2017-02-14 18:02:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694813005/1
3 years, 10 months ago (2017-02-14 18:02:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/72c70c9d1f6b5453aeb518610b2fa581bed511aa
3 years, 10 months ago (2017-02-14 18:06:50 UTC) #7
Garrett Casto
3 years, 10 months ago (2017-02-14 18:10:18 UTC) #8
Message was sent while issue was closed.
On 2017/02/14 18:06:50, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/72c70c9d1f6b5453aeb518610b2f...

Looks like this also caused a failure in the Windows builder
(https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...):

ninja -t msvc -e environment.x86 -- C:\b\c\cipd\goma/gomacc.exe
"C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\bin\amd64_x86/cl.exe"
/nologo /showIncludes /FC
@obj/chrome/browser/ui/ui_1/version_updater_win.obj.rsp /c
../../chrome/browser/ui/webui/help/version_updater_win.cc
/Foobj/chrome/browser/ui/ui_1/version_updater_win.obj
/Fd"obj/chrome/browser/ui/ui_1_cc.pdb"
c:\b\c\b\win_chrome\src\chrome\browser\ui\webui\help\version_updater_win.cc(58):
error C2664: 'bool base::PostTaskAndReplyWithResult<R,bool>(base::TaskRunner
*,const tracked_objects::Location &,base::Callback<R
(void),base::internal::CopyMode::Copyable,base::internal::RepeatMode::Repeating>,base::Callback<void
(bool),base::internal::CopyMode::Copyable,base::internal::RepeatMode::Repeating>)':
cannot convert argument 1 from 'base::SequencedWorkerPool *' to
'base::TaskRunner *'
        with
        [
            R=bool
        ]
c:\b\c\b\win_chrome\src\chrome\browser\ui\webui\help\version_updater_win.cc(58):
note: Types pointed to are unrelated; conversion requires reinterpret_cast,
C-style cast or function-style cast
[31889/38409] CXX obj/chrome/browser/ui/ui_2/about_handler.obj

Powered by Google App Engine
This is Rietveld 408576698