Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2694803002:
Switch views_mus_interactive_ui_tests to use swarming. (Closed)
DescriptionSwitch CrOS mus tests to use swarming.
Tests on linux_chromium_chromeos_ozone_rel_ng that don't use swarming
have been flakey recently and I think it might be related to switching
mash_browser_tests to use swarming.
It's possible this is a symptom of some timing issue. Before
https://crrev.com/2680283003 mash_browser_tests would always run first
then views_mus_interactive_ui_tests second. Otherwise there is no
dependencies from views_mus_interactive_ui_tests to mash_browser-tests.
At this point there is no reasons the tests shouldn't be using swarming,
so it's worth checking.
BUG=689682
Review-Url: https://codereview.chromium.org/2694803002
Cr-Commit-Position: refs/heads/master@{#450206}
Committed: https://chromium.googlesource.com/chromium/src/+/b190459e78a61ae6000cd5c8fde6464d29171183
Patch Set 1 #Patch Set 2 : Other tests to swarming. #Messages
Total messages: 19 (15 generated)
Description was changed from ========== Try views_mus_interactive_ui_tests with swarming. Trying to see if this works and if this impacts flakiness. BUG=none ========== to ========== Switch views_mus_interactive_ui_tests to use swarming. The tests has been flakey on linux_chromium_chromeos_ozone_rel_ng recently and I think it might be related to switching mash_browser_tests to use swarming. I'm unsure of exactly why this is the case. BUG=689682 ==========
Description was changed from ========== Switch views_mus_interactive_ui_tests to use swarming. The tests has been flakey on linux_chromium_chromeos_ozone_rel_ng recently and I think it might be related to switching mash_browser_tests to use swarming. I'm unsure of exactly why this is the case. BUG=689682 ========== to ========== Switch views_mus_interactive_ui_tests to use swarming. The tests has been flakey on linux_chromium_chromeos_ozone_rel_ng recently and I think it might be related to switching mash_browser_tests to use swarming. I'm not sure exactly why this would be a problem but interactive_ui_tests also uses swarming so it's worth a shot. BUG=689682 ==========
The CQ bit was checked by kylechar@chromium.org to run a CQ dry run
Description was changed from ========== Switch views_mus_interactive_ui_tests to use swarming. The tests has been flakey on linux_chromium_chromeos_ozone_rel_ng recently and I think it might be related to switching mash_browser_tests to use swarming. I'm not sure exactly why this would be a problem but interactive_ui_tests also uses swarming so it's worth a shot. BUG=689682 ========== to ========== Switch views_mus_interactive_ui_tests to use swarming. The tests has been flakey on linux_chromium_chromeos_ozone_rel_ng recently and I think it might be related to switching mash_browser_tests to use swarming. I'm not sure exactly why this would be a problem but interactive_ui_tests also uses swarming so it's worth a shot. BUG=689682 ==========
kylechar@chromium.org changed reviewers: + sky@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM
The CQ bit was checked by kylechar@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Switch views_mus_interactive_ui_tests to use swarming. The tests has been flakey on linux_chromium_chromeos_ozone_rel_ng recently and I think it might be related to switching mash_browser_tests to use swarming. I'm not sure exactly why this would be a problem but interactive_ui_tests also uses swarming so it's worth a shot. BUG=689682 ========== to ========== Switch CrOS mus tests to use swarming. Tests on linux_chromium_chromeos_ozone_rel_ng that don't use swarming have been flakey recently and I think it might be related to switching mash_browser_tests to use swarming. It's possible this is a symptom of some timing issue. Before https://crrev.com/2680283003 mash_browser_tests would always run first then views_mus_interactive_ui_tests second. Otherwise there is no dependencies from views_mus_interactive_ui_tests to mash_browser-tests. At this point there is no reasons the tests shouldn't be using swarming, so it's worth checking. BUG=689682 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kylechar@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org Link to the patchset: https://codereview.chromium.org/2694803002/#ps20001 (title: "Other tests to swarming.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487039134369530,
"parent_rev": "b874581aab39ed174ed99b4fd2d115bd1e375a2a", "commit_rev":
"b190459e78a61ae6000cd5c8fde6464d29171183"}
Message was sent while issue was closed.
Description was changed from ========== Switch CrOS mus tests to use swarming. Tests on linux_chromium_chromeos_ozone_rel_ng that don't use swarming have been flakey recently and I think it might be related to switching mash_browser_tests to use swarming. It's possible this is a symptom of some timing issue. Before https://crrev.com/2680283003 mash_browser_tests would always run first then views_mus_interactive_ui_tests second. Otherwise there is no dependencies from views_mus_interactive_ui_tests to mash_browser-tests. At this point there is no reasons the tests shouldn't be using swarming, so it's worth checking. BUG=689682 ========== to ========== Switch CrOS mus tests to use swarming. Tests on linux_chromium_chromeos_ozone_rel_ng that don't use swarming have been flakey recently and I think it might be related to switching mash_browser_tests to use swarming. It's possible this is a symptom of some timing issue. Before https://crrev.com/2680283003 mash_browser_tests would always run first then views_mus_interactive_ui_tests second. Otherwise there is no dependencies from views_mus_interactive_ui_tests to mash_browser-tests. At this point there is no reasons the tests shouldn't be using swarming, so it's worth checking. BUG=689682 Review-Url: https://codereview.chromium.org/2694803002 Cr-Commit-Position: refs/heads/master@{#450206} Committed: https://chromium.googlesource.com/chromium/src/+/b190459e78a61ae6000cd5c8fde6... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/b190459e78a61ae6000cd5c8fde6... |
