Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Issue 2694743002: Remove uses of GoogleUpdateSettings::GetChromeChannel in Chrome. (Closed)

Created:
3 years, 10 months ago by grt (UTC plus 2)
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove uses of GoogleUpdateSettings::GetChromeChannel in Chrome. - MainDllLoader::Launch doesn't need to know the channel. - chrome::GetChannel and GetChannelString now use InstallDetails. BUG=373987 R=jochen@chromium.org Review-Url: https://codereview.chromium.org/2694743002 Cr-Commit-Position: refs/heads/master@{#450312} Committed: https://chromium.googlesource.com/chromium/src/+/f07ca90e103c3d76fd7e2c8d44621e8040c184cf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -23 lines) Patch
M chrome/app/main_dll_loader_win.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/common/channel_info_win.cc View 3 chunks +3 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
grt (UTC plus 2)
PTAL, thanks.
3 years, 10 months ago (2017-02-13 13:33:22 UTC) #1
jochen (gone - plz use gerrit)
lgtm
3 years, 10 months ago (2017-02-14 09:04:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694743002/1
3 years, 10 months ago (2017-02-14 10:21:20 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 10:25:37 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f07ca90e103c3d76fd7e2c8d4462...

Powered by Google App Engine
This is Rietveld 408576698