Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1317)

Issue 2694723002: [turbofan] attempt to fix OOM caused by escape analysis (Closed)

Created:
3 years, 10 months ago by Tobias Tebbi
Modified:
3 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] attempt to fix OOM caused by escape analysis My hypothesis is that the OOM crash is caused by a loop of forgetting and reallocating a VirtualObject inside of a VirtualState. R=mstarzinger@chromium.org BUG=chromium:691487 Review-Url: https://codereview.chromium.org/2694723002 Cr-Commit-Position: refs/heads/master@{#43184} Committed: https://chromium.googlesource.com/v8/v8/+/c176c6c4e7b56ca7c80d405fe026f5925849356d

Patch Set 1 #

Patch Set 2 : fixed mistake #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M src/compiler/escape-analysis.cc View 1 4 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tobias Tebbi
3 years, 10 months ago (2017-02-13 12:57:21 UTC) #1
Michael Starzinger
LGTM.
3 years, 10 months ago (2017-02-14 11:33:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694723002/20001
3 years, 10 months ago (2017-02-14 11:34:05 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 12:27:37 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/c176c6c4e7b56ca7c80d405fe026f592584...

Powered by Google App Engine
This is Rietveld 408576698