Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issue 2694713006: [Telemetry] Make fetch_benchmark_deps_unittest mock archive_info2 (Closed)

Created:
3 years, 10 months ago by rnephew (Reviews Here)
Modified:
3 years, 10 months ago
Reviewers:
nednguyen, achuithb
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Make fetch_benchmark_deps_unittest mock archive_info2 Before it was using the old archive_info BUG=692278 Review-Url: https://codereview.chromium.org/2694713006 Cr-Commit-Position: refs/heads/master@{#450739} Committed: https://chromium.googlesource.com/chromium/src/+/f9069e1c70a2a07fcf187d5a3670497470fd1cf3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/perf/fetch_benchmark_deps_unittest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
rnephew (Reviews Here)
3 years, 10 months ago (2017-02-15 15:54:27 UTC) #2
nednguyen
lgtm
3 years, 10 months ago (2017-02-15 15:55:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694713006/1
3 years, 10 months ago (2017-02-15 15:56:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f9069e1c70a2a07fcf187d5a3670497470fd1cf3
3 years, 10 months ago (2017-02-15 17:31:43 UTC) #8
rnephew (Reviews Here)
3 years, 9 months ago (2017-03-03 17:06:49 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2734473002/ by rnephew@chromium.org.

The reason for reverting is: Fix landed..

Powered by Google App Engine
This is Rietveld 408576698